From: Herve Codina <herve.codina@bootlin.com>
To: wangweidong.a@awinic.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
perex@perex.cz, tiwai@suse.com, shumingf@realtek.com,
rf@opensource.cirrus.com, arnd@arndb.de, 13916275206@139.com,
ryans.lee@analog.com, linus.walleij@linaro.org,
ckeepax@opensource.cirrus.com, fido_max@inbox.ru,
sebastian.reichel@collabora.com, colin.i.king@gmail.com,
liweilei@awinic.com, trix@redhat.com, dan.carpenter@linaro.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/3] ASoC: codecs: Add code for bin parsing compatible with aw88399
Date: Sat, 14 Oct 2023 14:28:03 +0200 [thread overview]
Message-ID: <20231014142803.43f2aa9b@bootlin.com> (raw)
In-Reply-To: <20231013104220.279953-3-wangweidong.a@awinic.com>
Hi Weidong,
On Fri, 13 Oct 2023 18:42:19 +0800
wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> Add aw88399 compatible code to the aw88395_lib.c file
> so that it can parse aw88399's bin file.
>
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
> sound/soc/codecs/aw88395/aw88395_lib.c | 3 +++
> sound/soc/codecs/aw88395/aw88395_reg.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/sound/soc/codecs/aw88395/aw88395_lib.c b/sound/soc/codecs/aw88395/aw88395_lib.c
> index 87dd0ccade4c..692ad9fa65a6 100644
> --- a/sound/soc/codecs/aw88395/aw88395_lib.c
> +++ b/sound/soc/codecs/aw88395/aw88395_lib.c
> @@ -702,6 +702,7 @@ static int aw_dev_load_cfg_by_hdr(struct aw_device *aw_dev,
> }
>
> switch (aw_dev->chip_id) {
> + case AW88399_CHIP_ID:
Just a nitpick here.
You can use the same 'switch case' order as for the other 'switch cases' below.
I mean
case AW88395_CHIP_ID:
case AW88399_CHIP_ID:
With that done:
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
> case AW88395_CHIP_ID:
> ret = aw88395_dev_cfg_get_valid_prof(aw_dev, *all_prof_info);
> if (ret < 0)
> @@ -791,6 +792,7 @@ static int aw_get_dev_scene_count_v1(struct aw_device *aw_dev, struct aw_contain
>
> switch (aw_dev->chip_id) {
> case AW88395_CHIP_ID:
> + case AW88399_CHIP_ID:
> for (i = 0; i < cfg_hdr->ddt_num; ++i) {
> if ((cfg_dde[i].data_type == ACF_SEC_TYPE_MULTIPLE_BIN) &&
> (aw_dev->chip_id == cfg_dde[i].chip_id) &&
> @@ -832,6 +834,7 @@ static int aw_get_default_scene_count_v1(struct aw_device *aw_dev,
>
> switch (aw_dev->chip_id) {
> case AW88395_CHIP_ID:
> + case AW88399_CHIP_ID:
> for (i = 0; i < cfg_hdr->ddt_num; ++i) {
> if ((cfg_dde[i].data_type == ACF_SEC_TYPE_MULTIPLE_BIN) &&
> (aw_dev->chip_id == cfg_dde[i].chip_id) &&
[...]
Best regards,
Hervé
next prev parent reply other threads:[~2023-10-14 12:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 10:42 [PATCH V1 0/3] ASoC: codecs: Add aw88399 amplifier driver wangweidong.a
2023-10-13 10:42 ` [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw88399" wangweidong.a
2023-10-13 11:50 ` Krzysztof Kozlowski
2023-10-13 10:42 ` [PATCH V1 2/3] ASoC: codecs: Add code for bin parsing compatible with aw88399 wangweidong.a
2023-10-14 12:28 ` Herve Codina [this message]
2023-10-13 10:42 ` [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver wangweidong.a
2023-10-13 11:50 ` Krzysztof Kozlowski
2023-10-13 14:14 ` Mark Brown
2023-10-16 8:05 ` wangweidong.a
2023-10-13 14:10 ` Mark Brown
2023-10-16 8:10 ` wangweidong.a
2023-10-16 9:07 ` wangweidong.a
2023-10-16 11:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014142803.43f2aa9b@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=colin.i.king@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fido_max@inbox.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=ryans.lee@analog.com \
--cc=sebastian.reichel@collabora.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
--cc=wangweidong.a@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox