From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Shanker Donthineni <sdonthineni@nvidia.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] rtc: efi: fixed typo in efi_procfs()
Date: Sun, 15 Oct 2023 22:57:06 +0200 [thread overview]
Message-ID: <20231015205706326de111@mail.local> (raw)
In-Reply-To: <20231006090444.306729-1-korotkov.maxim.s@gmail.com>
On 06/10/2023 12:04:44+0300, Maxim Korotkov wrote:
> After the first check of the value of the "eft" variable
> it does not change, it is obvious that a copy-paste
> error was made here and the value of variable "alm"
> should be checked here.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 101ca8d05913 ("rtc: efi: Enable SET/GET WAKEUP services as optional")
I had a look at the history and this is actually a bug that predates
v2.6.12-rc2 and so its introduction is not in the main git repo history.
I guess nobody actually cares and I'm very tempted to just rip out this
procfs file.
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
> ---
> drivers/rtc/rtc-efi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c
> index dc6b0f4a54e2..fa8bf82df948 100644
> --- a/drivers/rtc/rtc-efi.c
> +++ b/drivers/rtc/rtc-efi.c
> @@ -227,7 +227,7 @@ static int efi_procfs(struct device *dev, struct seq_file *seq)
> enabled == 1 ? "yes" : "no",
> pending == 1 ? "yes" : "no");
>
> - if (eft.timezone == EFI_UNSPECIFIED_TIMEZONE)
> + if (alm.timezone == EFI_UNSPECIFIED_TIMEZONE)
> seq_puts(seq, "Timezone\t: unspecified\n");
> else
> /* XXX fixme: convert to string? */
> --
> 2.34.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-10-15 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 9:04 [PATCH] rtc: efi: fixed typo in efi_procfs() Maxim Korotkov
2023-10-15 20:57 ` Alexandre Belloni [this message]
2023-10-15 21:03 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231015205706326de111@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=korotkov.maxim.s@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=sdonthineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox