Re: linux-next: build failure after merge of the rtc tree

Alexandre Belloni
2023-10-16T04:34:25Z

On 16/10/2023 15:15:22+1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the rtc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/rtc/rtc-at91rm9200.c:561:13: error: 'at91_rtc_remove' defined but not used [-Werror=unused-function]
> 561 | static void at91_rtc_remove(struct platform_device *pdev)
> | ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 48bc8830fbed ("rtc: at91rm9200: Convert to platform remove callback returning void")
>
> This function lost its __exit attribute (which includes a "used"
> attribute) and exit_p(x) is NULL when not being built with
> CONFIG_MODULE set. This build has CONFIG_RTC_DRV_AT91RM9200=y
>
> I have reverted that commit for today.
>

Thanks for the report, this is fixed now.

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering