public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Florian Eckert <fe@dev.tdt.de>
To: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org,
	kabel@kernel.org, u.kleine-koenig@pengutronix.de
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-leds@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top
Date: Mon, 16 Oct 2023 09:13:31 +0200	[thread overview]
Message-ID: <20231016071332.597654-4-fe@dev.tdt.de> (raw)
In-Reply-To: <20231016071332.597654-1-fe@dev.tdt.de>

Has complained about the following construct:
drivers/leds/trigger/ledtrig-tty.c:362:3: error: a label can only be
part of a statement and a declaration is not a statement

Hence move the variable definition to the beginning of the function.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@intel.com/
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
---
 drivers/leds/trigger/ledtrig-tty.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/ledtrig-tty.c
index 8ae0d2d284af..1c6fadf0b856 100644
--- a/drivers/leds/trigger/ledtrig-tty.c
+++ b/drivers/leds/trigger/ledtrig-tty.c
@@ -82,6 +82,7 @@ static void ledtrig_tty_work(struct work_struct *work)
 {
 	struct ledtrig_tty_data *trigger_data =
 		container_of(work, struct ledtrig_tty_data, dwork.work);
+	unsigned long interval = LEDTRIG_TTY_INTERVAL;
 	struct serial_icounter_struct icount;
 	int ret;
 
@@ -124,8 +125,6 @@ static void ledtrig_tty_work(struct work_struct *work)
 
 	if (icount.rx != trigger_data->rx ||
 	    icount.tx != trigger_data->tx) {
-		unsigned long interval = LEDTRIG_TTY_INTERVAL;
-
 		led_blink_set_oneshot(trigger_data->led_cdev, &interval,
 				      &interval, 0);
 
-- 
2.30.2


  parent reply	other threads:[~2023-10-16  7:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16  7:13 [PATCH v3 0/4] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-10-16  7:13 ` [PATCH v3 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-16 12:32   ` Jiri Slaby
2023-10-18 10:56     ` Florian Eckert
2023-10-18 13:34       ` Greg KH
2023-10-16  7:13 ` [PATCH v3 2/4] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-16  7:13 ` Florian Eckert [this message]
2023-10-16  8:46   ` [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top m.brock
2023-10-16  9:12     ` Florian Eckert
2023-10-16 12:39       ` Jiri Slaby
2023-10-19  9:12       ` m.brock
2023-10-16  7:13 ` [PATCH v3 4/4] trigger: ledtrig-tty: add new line mode to triggers Florian Eckert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016071332.597654-4-fe@dev.tdt.de \
    --to=fe@dev.tdt.de \
    --cc=Eckert.Florian@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kabel@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=pavel@ucw.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox