From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"zhenzhong.duan@intel.com" <zhenzhong.duan@intel.com>,
"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>
Subject: Re: [PATCH v2 1/6] iommu: Add new iommu op to create domains owned by userspace
Date: Mon, 16 Oct 2023 09:04:54 -0300 [thread overview]
Message-ID: <20231016120454.GS3952@nvidia.com> (raw)
In-Reply-To: <ZSuROTyaxePoVFA+@Asurada-Nvidia>
On Sun, Oct 15, 2023 at 12:14:01AM -0700, Nicolin Chen wrote:
> On Thu, Sep 28, 2023 at 12:15:23AM -0700, Yi Liu wrote:
>
> > diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
> > index b4ba0c0cbab6..4a7c5c8fdbb4 100644
> > --- a/include/uapi/linux/iommufd.h
> > +++ b/include/uapi/linux/iommufd.h
> > @@ -347,10 +347,20 @@ struct iommu_vfio_ioas {
> > };
> > #define IOMMU_VFIO_IOAS _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VFIO_IOAS)
> >
> > +/**
> > + * enum iommufd_hwpt_alloc_flags - Flags for HWPT allocation
> > + * @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a domain which can serve
> > + * as the parent domain in the nesting
> > + * configuration.
>
> I just noticed a nit here: we should probably align with other
> parts of this file by using "HWPT" v.s. "domain"? I.e.
>
> + * @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a HWPT which can serve
> + * as the parent HWPT in the nesting
> + * configuration.
Yes
Jason
next prev parent reply other threads:[~2023-10-16 12:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 7:15 [PATCH v2 0/6] iommufd support allocating nested parent domain Yi Liu
2023-09-28 7:15 ` [PATCH v2 1/6] iommu: Add new iommu op to create domains owned by userspace Yi Liu
2023-10-09 1:09 ` Tian, Kevin
2023-10-15 7:14 ` Nicolin Chen
2023-10-16 12:04 ` Jason Gunthorpe [this message]
2023-10-16 17:46 ` Nicolin Chen
2023-10-17 16:05 ` Jason Gunthorpe
2023-09-28 7:15 ` [PATCH v2 2/6] iommufd/hw_pagetable: Use domain_alloc_user op for domain allocation Yi Liu
[not found] ` <00163e5f-1a5a-a5c6-baa1-12b2a97e12b7@intel.com>
2023-10-16 17:48 ` Nicolin Chen
2023-10-17 3:46 ` Liu, Jingqi
2023-09-28 7:15 ` [PATCH v2 3/6] iommufd/hw_pagetable: Accepts user flags " Yi Liu
2023-09-29 3:33 ` Baolu Lu
2023-09-28 7:15 ` [PATCH v2 4/6] iommufd/hw_pagetable: Support allocating nested parent domain Yi Liu
2023-09-29 3:34 ` Baolu Lu
2023-10-09 1:10 ` Tian, Kevin
2023-09-28 7:15 ` [PATCH v2 5/6] iommufd/selftest: Add domain_alloc_user() support in iommu mock Yi Liu
2023-10-09 1:12 ` Tian, Kevin
2023-09-28 7:15 ` [PATCH v2 6/6] iommu/vt-d: Add domain_alloc_user op Yi Liu
2023-09-29 3:38 ` Baolu Lu
2023-10-09 1:13 ` Tian, Kevin
2023-10-10 16:43 ` Jason Gunthorpe
2023-10-11 3:18 ` Baolu Lu
2023-10-10 16:47 ` [PATCH v2 0/6] iommufd support allocating nested parent domain Jason Gunthorpe
2023-10-12 7:33 ` Yi Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016120454.GS3952@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox