* [PATCH] dt-bindings: usb: ti,tps6598x: Disallow undefined properties
@ 2023-10-16 15:55 Rob Herring
2023-10-16 18:03 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-10-16 15:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Krzysztof Kozlowski, Conor Dooley,
Bryan O'Donoghue
Cc: linux-usb, devicetree, linux-kernel
Device specific bindings should not allow undefined properties. This is
accomplished in json-schema with 'additionalProperties: false'. With this,
the 'connector' child node needs to be defined to prevent warnings.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
index 5497a60cddbc..6ab674dea4c6 100644
--- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
@@ -32,11 +32,14 @@ properties:
items:
- const: irq
+ connector:
+ $ref: /schemas/connector/usb-connector.yaml#
+
required:
- compatible
- reg
-additionalProperties: true
+additionalProperties: false
examples:
- |
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: usb: ti,tps6598x: Disallow undefined properties
2023-10-16 15:55 [PATCH] dt-bindings: usb: ti,tps6598x: Disallow undefined properties Rob Herring
@ 2023-10-16 18:03 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-10-16 18:03 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, Bryan O'Donoghue,
linux-usb, devicetree, linux-kernel
On Mon, Oct 16, 2023 at 10:55:27AM -0500, Rob Herring wrote:
> Device specific bindings should not allow undefined properties. This is
> accomplished in json-schema with 'additionalProperties: false'. With this,
> the 'connector' child node needs to be defined to prevent warnings.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> index 5497a60cddbc..6ab674dea4c6 100644
> --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> @@ -32,11 +32,14 @@ properties:
> items:
> - const: irq
>
> + connector:
> + $ref: /schemas/connector/usb-connector.yaml#
> +
> required:
> - compatible
> - reg
>
> -additionalProperties: true
> +additionalProperties: false
>
> examples:
> - |
> --
> 2.42.0
>
>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-16 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 15:55 [PATCH] dt-bindings: usb: ti,tps6598x: Disallow undefined properties Rob Herring
2023-10-16 18:03 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox