* [PATCH] dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema
@ 2023-10-16 15:55 Rob Herring
2023-10-16 19:24 ` Krzysztof Kozlowski
2023-10-30 21:02 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-10-16 15:55 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Rao Mandadapu
Cc: linux-arm-msm, devicetree, linux-kernel
The soundwire-controller.yaml schema already defines the form for devices
in child nodes, so there's no need to do the same in the QCom controller
binding. Add a $ref to the soundwire-controller.yaml schema and drop the
child node schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/soundwire/qcom,soundwire.yaml | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
index 7d60a9654912..3591c8c49bfe 100644
--- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
+++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml
@@ -209,17 +209,6 @@ properties:
label:
maxItems: 1
-patternProperties:
- "^.*@[0-9a-f],[0-9a-f]$":
- type: object
- additionalProperties: true
- description:
- Child nodes for a standalone audio codec or speaker amplifier IC.
- It has RX and TX Soundwire secondary devices.
- properties:
- compatible:
- pattern: "^sdw[0-9a-f]{1}[0-9a-f]{4}[0-9a-f]{4}[0-9a-f]{2}$"
-
required:
- compatible
- reg
@@ -240,7 +229,10 @@ oneOf:
- required:
- qcom,ports-sinterval
-additionalProperties: false
+allOf:
+ - $ref: soundwire-controller.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema
2023-10-16 15:55 [PATCH] dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema Rob Herring
@ 2023-10-16 19:24 ` Krzysztof Kozlowski
2023-10-30 21:02 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-16 19:24 UTC (permalink / raw)
To: Rob Herring, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Rao Mandadapu
Cc: linux-arm-msm, devicetree, linux-kernel
On 16/10/2023 17:55, Rob Herring wrote:
> The soundwire-controller.yaml schema already defines the form for devices
> in child nodes, so there's no need to do the same in the QCom controller
> binding. Add a $ref to the soundwire-controller.yaml schema and drop the
> child node schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema
2023-10-16 15:55 [PATCH] dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema Rob Herring
2023-10-16 19:24 ` Krzysztof Kozlowski
@ 2023-10-30 21:02 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-10-30 21:02 UTC (permalink / raw)
To: Rob Herring
Cc: Rao Mandadapu, Bjorn Andersson, linux-kernel, Conor Dooley,
linux-arm-msm, Srinivas Kandagatla, Krzysztof Kozlowski,
devicetree, Andy Gross, Konrad Dybcio
On Mon, 16 Oct 2023 10:55:37 -0500, Rob Herring wrote:
> The soundwire-controller.yaml schema already defines the form for devices
> in child nodes, so there's no need to do the same in the QCom controller
> binding. Add a $ref to the soundwire-controller.yaml schema and drop the
> child node schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/soundwire/qcom,soundwire.yaml | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-30 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 15:55 [PATCH] dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema Rob Herring
2023-10-16 19:24 ` Krzysztof Kozlowski
2023-10-30 21:02 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox