* [PATCH] drm/msm/a6xx: add QMP dependency
@ 2023-10-16 20:04 Arnd Bergmann
2023-10-17 12:24 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-10-16 20:04 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, David Airlie,
Daniel Vetter, Konrad Dybcio
Cc: Arnd Bergmann, Sean Paul, Marijn Suijten, Ulf Hansson,
Thomas Zimmermann, Randy Dunlap, Neil Armstrong, Akhil P Oommen,
linux-arm-msm, dri-devel, freedreno, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When QMP is in a loadable module, the A6xx GPU driver fails to link
as built-in:
x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'
Add the usual dependency that still allows compiling without QMP but
otherwise avoids the broken combination of options.
Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/msm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 6309a857ca312..ad70b611b44f0 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -6,6 +6,7 @@ config DRM_MSM
depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
depends on COMMON_CLK
depends on IOMMU_SUPPORT
+ depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n
depends on QCOM_OCMEM || QCOM_OCMEM=n
depends on QCOM_LLCC || QCOM_LLCC=n
depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/a6xx: add QMP dependency
2023-10-16 20:04 [PATCH] drm/msm/a6xx: add QMP dependency Arnd Bergmann
@ 2023-10-17 12:24 ` Konrad Dybcio
2023-12-01 23:48 ` Dmitry Baryshkov
2023-12-03 11:26 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-10-17 12:24 UTC (permalink / raw)
To: Arnd Bergmann, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
David Airlie, Daniel Vetter
Cc: Arnd Bergmann, Sean Paul, Marijn Suijten, Ulf Hansson,
Thomas Zimmermann, Randy Dunlap, Neil Armstrong, Akhil P Oommen,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 10/16/23 22:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When QMP is in a loadable module, the A6xx GPU driver fails to link
> as built-in:
>
> x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
> a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'
>
> Add the usual dependency that still allows compiling without QMP but
> otherwise avoids the broken combination of options.
>
> Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Right, thanks!
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/a6xx: add QMP dependency
2023-10-16 20:04 [PATCH] drm/msm/a6xx: add QMP dependency Arnd Bergmann
2023-10-17 12:24 ` Konrad Dybcio
@ 2023-12-01 23:48 ` Dmitry Baryshkov
2023-12-03 11:26 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-12-01 23:48 UTC (permalink / raw)
To: Arnd Bergmann, Rob Clark, Abhinav Kumar, David Airlie,
Daniel Vetter, Konrad Dybcio
Cc: Arnd Bergmann, Sean Paul, Marijn Suijten, Ulf Hansson,
Thomas Zimmermann, Randy Dunlap, Neil Armstrong, Akhil P Oommen,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 16/10/2023 23:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When QMP is in a loadable module, the A6xx GPU driver fails to link
> as built-in:
>
> x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
> a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'
>
> Add the usual dependency that still allows compiling without QMP but
> otherwise avoids the broken combination of options.
>
> Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/msm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/a6xx: add QMP dependency
2023-10-16 20:04 [PATCH] drm/msm/a6xx: add QMP dependency Arnd Bergmann
2023-10-17 12:24 ` Konrad Dybcio
2023-12-01 23:48 ` Dmitry Baryshkov
@ 2023-12-03 11:26 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-12-03 11:26 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, David Airlie, Daniel Vetter,
Konrad Dybcio, Arnd Bergmann
Cc: Arnd Bergmann, Sean Paul, Marijn Suijten, Ulf Hansson,
Thomas Zimmermann, Randy Dunlap, Neil Armstrong, Akhil P Oommen,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On Mon, 16 Oct 2023 22:04:03 +0200, Arnd Bergmann wrote:
> When QMP is in a loadable module, the A6xx GPU driver fails to link
> as built-in:
>
> x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
> a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'
>
> Add the usual dependency that still allows compiling without QMP but
> otherwise avoids the broken combination of options.
>
> [...]
Applied, thanks!
[1/1] drm/msm/a6xx: add QMP dependency
https://gitlab.freedesktop.org/lumag/msm/-/commit/96ab215b2d5e
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-03 11:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 20:04 [PATCH] drm/msm/a6xx: add QMP dependency Arnd Bergmann
2023-10-17 12:24 ` Konrad Dybcio
2023-12-01 23:48 ` Dmitry Baryshkov
2023-12-03 11:26 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox