From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F7FBCDB465 for ; Mon, 16 Oct 2023 15:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229784AbjJPPBM (ORCPT ); Mon, 16 Oct 2023 11:01:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233772AbjJPPA7 (ORCPT ); Mon, 16 Oct 2023 11:00:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3639012B for ; Mon, 16 Oct 2023 08:00:54 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55C2CC433C7; Mon, 16 Oct 2023 15:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697468453; bh=0GLvmKMndiyVt2ULVPwCbqdYlF8TzgXDxAHUw0Tml34=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rS2G571HfKSELOJ65cQHDl05C83C7XrPtjD2iGcnZJQiCCAXXmXVv4RLjJ3Dj2XV/ FHHkasnnjelj+h0Muc4UED112XsdR8cbC7dOdmur6L4smOq8s3WK1+g5o3qn8o5aX0 XfP59iKl99MUMv/3XQmvYIBLxwSu80CphnkBzbUY= Date: Mon, 16 Oct 2023 16:57:16 +0200 From: Greg KH To: Gilbert Adikankwu Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: emxx_udc: Remove unnecessary parentheses around condition tests Message-ID: <2023101658-unmoral-survival-25cf@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2023 at 12:35:23PM +0100, Gilbert Adikankwu wrote: > Fix 47 warnings detected by checkpatch.pl about unnecessary parenthesis > around condition tests. And as I have stated numerous times in the past, they are not "unnecessary" at all, and provide a valuable hint to the developer as to what is the ordering involved. So you can ignore this checkpatch warning please, it's not valid as far as I'm concerned for the subsystems that I maintain in the kernel. sorry, greg k-h