From: "Mickaël Salaün" <mic@digikod.net>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] landlock: fix typo in landlock_append_net_rule() stub function
Date: Tue, 17 Oct 2023 21:48:10 +0200 [thread overview]
Message-ID: <20231017.ia3Aiv5Am5ee@digikod.net> (raw)
In-Reply-To: <20231017143341.2875980-1-arnd@kernel.org>
Thanks Arnd, I fixed the issue and squashed it in -next.
There will be a next patch series including other fixes.
On Tue, Oct 17, 2023 at 04:33:35PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> There is an extraneous semicolon in the empty stub helper for
> this function tha causes randconfig builds to break:
>
> In file included from security/landlock/setup.c:17:
> security/landlock/net.h:28:1: error: expected identifier or '(' before '{' token
> security/landlock/net.h:26:1: error: 'landlock_append_net_rule' declared 'static' but never defined [-Werror=unused-function]
>
> Fixes: 614d46b333ab9 ("landlock: Add network rules and TCP hooks support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> security/landlock/net.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/landlock/net.h b/security/landlock/net.h
> index 588a49fd69076..09960c237a13e 100644
> --- a/security/landlock/net.h
> +++ b/security/landlock/net.h
> @@ -24,7 +24,7 @@ static inline void landlock_add_net_hooks(void)
>
> static inline int
> landlock_append_net_rule(struct landlock_ruleset *const ruleset, const u16 port,
> - access_mask_t access_rights);
> + access_mask_t access_rights)
> {
> return -EAFNOSUPPORT;
> }
> --
> 2.39.2
>
prev parent reply other threads:[~2023-10-17 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 14:33 [PATCH] landlock: fix typo in landlock_append_net_rule() stub function Arnd Bergmann
2023-10-17 19:48 ` Mickaël Salaün [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017.ia3Aiv5Am5ee@digikod.net \
--to=mic@digikod.net \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jmorris@namei.org \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox