From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4058CDB474 for ; Tue, 17 Oct 2023 07:37:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234539AbjJQHhN (ORCPT ); Tue, 17 Oct 2023 03:37:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234656AbjJQHgx (ORCPT ); Tue, 17 Oct 2023 03:36:53 -0400 Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB0C3103 for ; Tue, 17 Oct 2023 00:36:51 -0700 (PDT) Received: by mail-ua1-x929.google.com with SMTP id a1e0cc1a2514c-7b5fd0b7522so1554379241.0 for ; Tue, 17 Oct 2023 00:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697528211; x=1698133011; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cxT7pzdJESncQ/+9UX6/pYk1WP7pzSl0ESvB6teChuU=; b=N4PouUvUPXdMGFCGy725Sjo9GsCmF1ksb61u7ioomtvpRTcsT2BEuoREoJ+kk1C6fF xy0+ywyvWCE+fL4AtsQ3u63cS8U0uWzBDloHPziZfPs0ZUeBxMZ8SFR7/h9+V6iV0Gah qMcozuXDAiRqp8BruQzlIVbtNb+A56OahvR68DjnFSMhqRyqo0usZTQ6oBFJ6Yo1af3C iS7wE8O09mxgCx3IRpYnYoieWTjBdpFtmzee0MXLWqz7VceP/DGiHXGYgSz+P9WHHu1c hIvseX0/0uU03n4zrWF9Vcg6lj0n3CcHwrvAUDQ8XH+o0Zxd8qE4WhSGWD+OGC73+bL+ 24MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697528211; x=1698133011; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cxT7pzdJESncQ/+9UX6/pYk1WP7pzSl0ESvB6teChuU=; b=RVDv6r4tzM21ZLNXkzs4n7KKnpvB7ZgLeeXWaRFmdK+7WwK+KNevaINSUjY/zGrQrw y682Vuwze80IWLllvfOjWeKKOQm3QounoPnpu9VEcIqiTmA2IIYkbv6t45c2F0KNMob+ cZGrmLzXf1suiV+STLqChWzYKWQr2c3gZXsW1lJwqJ7cv6/zB3i7m+kPA1PrMwqJzs6S geJs4u84TlvtQI4waBrS/f649QAekMrXWZYSNSfZR4hOMaNzCB7H/ZsoAlgxbcuudDn0 ogoov5PrhgO/hx1T5chs6uTK8XBNeI+RKvVQ4/Z5OYfdYFkn1JfKd7oVgKRozJlDUIM1 GBxg== X-Gm-Message-State: AOJu0YwQVPaeqTIp6z0ngXNfjmdzrauU609usYi1+51Pg2/krYRPG7mN QssZUtYUSBlV0iKtP5zc1wzz X-Google-Smtp-Source: AGHT+IGFV6Oy9oyt9cc9+QXaBhIphbHezPtFo1fpD4ru8RrTKL+MKRETflutZYL7NmHrrU3OkLGrxA== X-Received: by 2002:a05:6102:756:b0:457:cc6c:948f with SMTP id v22-20020a056102075600b00457cc6c948fmr1247130vsg.26.1697528210667; Tue, 17 Oct 2023 00:36:50 -0700 (PDT) Received: from thinkpad ([117.207.31.199]) by smtp.gmail.com with ESMTPSA id mk2-20020a056214580200b0064c9f754794sm342250qvb.86.2023.10.17.00.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 00:36:49 -0700 (PDT) Date: Tue, 17 Oct 2023 13:06:42 +0530 From: Manivannan Sadhasivam To: mhi@lists.linux.dev Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_msarkar@quicinc.com, schintav@quicinc.com, stable@vger.kernel.org Subject: Re: [PATCH] bus: mhi: ep: Do not allocate event ring element on stack Message-ID: <20231017073642.GA5274@thinkpad> References: <20230901073502.69385-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230901073502.69385-1-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 01, 2023 at 01:05:02PM +0530, Manivannan Sadhasivam wrote: > It is possible that the host controller driver would use DMA framework to > write the event ring element. So avoid allocating event ring element on the > stack as DMA cannot work on vmalloc memory. > > Cc: stable@vger.kernel.org > Fixes: 961aeb689224 ("bus: mhi: ep: Add support for sending events to the host") > Signed-off-by: Manivannan Sadhasivam Applied to mhi-next! - Mani > --- > drivers/bus/mhi/ep/main.c | 52 +++++++++++++++++++++++++-------------- > 1 file changed, 34 insertions(+), 18 deletions(-) > > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c > index 600881808982..66ca470bf302 100644 > --- a/drivers/bus/mhi/ep/main.c > +++ b/drivers/bus/mhi/ep/main.c > @@ -71,45 +71,61 @@ static int mhi_ep_send_event(struct mhi_ep_cntrl *mhi_cntrl, u32 ring_idx, > static int mhi_ep_send_completion_event(struct mhi_ep_cntrl *mhi_cntrl, struct mhi_ep_ring *ring, > struct mhi_ring_element *tre, u32 len, enum mhi_ev_ccs code) > { > - struct mhi_ring_element event = {}; > + struct mhi_ring_element *event = kzalloc(sizeof(struct mhi_ring_element), GFP_KERNEL); > + int ret; > + > + event->ptr = cpu_to_le64(ring->rbase + ring->rd_offset * sizeof(*tre)); > + event->dword[0] = MHI_TRE_EV_DWORD0(code, len); > + event->dword[1] = MHI_TRE_EV_DWORD1(ring->ch_id, MHI_PKT_TYPE_TX_EVENT); > > - event.ptr = cpu_to_le64(ring->rbase + ring->rd_offset * sizeof(*tre)); > - event.dword[0] = MHI_TRE_EV_DWORD0(code, len); > - event.dword[1] = MHI_TRE_EV_DWORD1(ring->ch_id, MHI_PKT_TYPE_TX_EVENT); > + ret = mhi_ep_send_event(mhi_cntrl, ring->er_index, event, MHI_TRE_DATA_GET_BEI(tre)); > + kfree(event); > > - return mhi_ep_send_event(mhi_cntrl, ring->er_index, &event, MHI_TRE_DATA_GET_BEI(tre)); > + return ret; > } > > int mhi_ep_send_state_change_event(struct mhi_ep_cntrl *mhi_cntrl, enum mhi_state state) > { > - struct mhi_ring_element event = {}; > + struct mhi_ring_element *event = kzalloc(sizeof(struct mhi_ring_element), GFP_KERNEL); > + int ret; > + > + event->dword[0] = MHI_SC_EV_DWORD0(state); > + event->dword[1] = MHI_SC_EV_DWORD1(MHI_PKT_TYPE_STATE_CHANGE_EVENT); > > - event.dword[0] = MHI_SC_EV_DWORD0(state); > - event.dword[1] = MHI_SC_EV_DWORD1(MHI_PKT_TYPE_STATE_CHANGE_EVENT); > + ret = mhi_ep_send_event(mhi_cntrl, 0, event, 0); > + kfree(event); > > - return mhi_ep_send_event(mhi_cntrl, 0, &event, 0); > + return ret; > } > > int mhi_ep_send_ee_event(struct mhi_ep_cntrl *mhi_cntrl, enum mhi_ee_type exec_env) > { > - struct mhi_ring_element event = {}; > + struct mhi_ring_element *event = kzalloc(sizeof(struct mhi_ring_element), GFP_KERNEL); > + int ret; > + > + event->dword[0] = MHI_EE_EV_DWORD0(exec_env); > + event->dword[1] = MHI_SC_EV_DWORD1(MHI_PKT_TYPE_EE_EVENT); > > - event.dword[0] = MHI_EE_EV_DWORD0(exec_env); > - event.dword[1] = MHI_SC_EV_DWORD1(MHI_PKT_TYPE_EE_EVENT); > + ret = mhi_ep_send_event(mhi_cntrl, 0, event, 0); > + kfree(event); > > - return mhi_ep_send_event(mhi_cntrl, 0, &event, 0); > + return ret; > } > > static int mhi_ep_send_cmd_comp_event(struct mhi_ep_cntrl *mhi_cntrl, enum mhi_ev_ccs code) > { > + struct mhi_ring_element *event = kzalloc(sizeof(struct mhi_ring_element), GFP_KERNEL); > struct mhi_ep_ring *ring = &mhi_cntrl->mhi_cmd->ring; > - struct mhi_ring_element event = {}; > + int ret; > + > + event->ptr = cpu_to_le64(ring->rbase + ring->rd_offset * sizeof(struct mhi_ring_element)); > + event->dword[0] = MHI_CC_EV_DWORD0(code); > + event->dword[1] = MHI_CC_EV_DWORD1(MHI_PKT_TYPE_CMD_COMPLETION_EVENT); > > - event.ptr = cpu_to_le64(ring->rbase + ring->rd_offset * sizeof(struct mhi_ring_element)); > - event.dword[0] = MHI_CC_EV_DWORD0(code); > - event.dword[1] = MHI_CC_EV_DWORD1(MHI_PKT_TYPE_CMD_COMPLETION_EVENT); > + ret = mhi_ep_send_event(mhi_cntrl, 0, event, 0); > + kfree(event); > > - return mhi_ep_send_event(mhi_cntrl, 0, &event, 0); > + return ret; > } > > static int mhi_ep_process_cmd_ring(struct mhi_ep_ring *ring, struct mhi_ring_element *el) > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்