From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 24408CDB482
	for <linux-kernel@archiver.kernel.org>; Tue, 17 Oct 2023 08:58:23 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234797AbjJQI6W (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 17 Oct 2023 04:58:22 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43212 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234782AbjJQI6S (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2023 04:58:18 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40D2A8E
        for <linux-kernel@vger.kernel.org>; Tue, 17 Oct 2023 01:58:17 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA962C433C9;
        Tue, 17 Oct 2023 08:58:14 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1697533096;
        bh=ai4SUF4E5CkgY9PAcDU6r0weDFiwnBjcYowBmrlv3lU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=OZmMzkaThqW4ml7KX+DSLpxf5Riq/6HRRf1y+pDlc6bVlVgkj5HJnQWmRl5S9+5Yr
         Ceu0/hDxJPbxeK0KyucKWMTRHl/fIZAnOvNYH/Hn8vkEL54evdkj+5Ve5nmfW6Ebjn
         2q0qb2olb3hNPy5hnSgCIY/DtBBB1scf8IGiD8J1ZCPMvJD+cIp7NeLABFdr77AKJr
         5dP7LzQu2h2VYzfCh7Sy8viaxjLfYsrh7DAU79PSmgJeYkLyyepqFQIuioB7cr6Yg3
         ZO47ij2TuOqLsq0ycH7JCpewBytdNDJmsdIqIgAjXkOLOBpCHZ8cQ+szSz2JNb5n02
         Q0YgBAYQzuf5w==
Date:   Tue, 17 Oct 2023 10:58:13 +0200
From:   Simon Horman <horms@kernel.org>
To:     Davide Caratti <dcaratti@redhat.com>
Cc:     Matthieu Baerts <matttbe@kernel.org>, mptcp@lists.linux.dev,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Mat Martineau <martineau@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/6] uapi: mptcp: use header file generated from
 YAML spec
Message-ID: <20231017085813.GP1751252@kernel.org>
References: <20231010-upstream-net-next-20231006-mptcp-ynl-v1-0-18dd117e8f50@kernel.org>
 <20231010-upstream-net-next-20231006-mptcp-ynl-v1-4-18dd117e8f50@kernel.org>
 <20231013172823.GR29570@kernel.org>
 <CAKa-r6uYbhF3zZrDaZdCE1fo4A8WF0MHNGmLS21fh11WcSfqOg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKa-r6uYbhF3zZrDaZdCE1fo4A8WF0MHNGmLS21fh11WcSfqOg@mail.gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 14, 2023 at 01:37:43PM +0200, Davide Caratti wrote:
> hello Simon, thanks for reading!
> 
> On Fri, Oct 13, 2023 at 7:30 PM Simon Horman <horms@kernel.org> wrote:
> >
> > On Tue, Oct 10, 2023 at 09:21:45PM +0200, Matthieu Baerts wrote:
> > > From: Davide Caratti <dcaratti@redhat.com>
> > >
> > > generated with:
> > >
> > >  $ ./tools/net/ynl/ynl-gen-c.py --mode uapi \
> > >  > --spec Documentation/netlink/specs/mptcp.yaml \
> > >  > --header -o include/uapi/linux/mptcp_pm.h
> 
> [...]
> 
> > > +/**
> > > + * enum mptcp_event_type
> >
> > Hi Davide and Matthieu,
> >
> > I understand that is autogenerated.
> > But it is missing an entry here for @MPTCP_EVENT_UNSPEC.
> > Can that be addressed somehow?
> 
> probably it just needs
>     doc: unused event
> 
> in the YAML file, I will add it and regenerate the uAPI header

Thanks!