From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB41CDB474 for ; Tue, 17 Oct 2023 03:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234353AbjJQDtq (ORCPT ); Mon, 16 Oct 2023 23:49:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231856AbjJQDto (ORCPT ); Mon, 16 Oct 2023 23:49:44 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56D5C83 for ; Mon, 16 Oct 2023 20:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697514582; x=1729050582; h=date:from:to:cc:subject:message-id:mime-version; bh=wlI3zKs2oU4s933zH5wncMw0tBDTCnVQTnLxeE6vOSw=; b=exZ+Yt6RgYzxTUGht875m9TJwabnYZK7cXhTSuIt/pJHEQj2Dxltgci9 eTwCWUd2YnkyDUzEMIeNjYrMlWKyznTHXUA4X6Z3K89cxTfclFJgO6gtd NIIv18ITqXst1kfl1pB5W7zPGUNHy2VC9V4mxePAyEXqOh+NT4UV1y477 JLjfkmn7tDudyoqBCT+90O2xWRA+G7IzJ+92B4rZfXKptlapVC00cdby/ 3edTNguhLCC0i3mzojsWc2qBgn02+D+SeUNnTMhKgnrqd1TUfH3pFhBlj 3JsTujmsQNWWpZjjCzqjNhvoc6smLFT6Pkl3OkVy4AHVtsiOuVdzCiIrT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="4296807" X-IronPort-AV: E=Sophos;i="6.03,231,1694761200"; d="scan'208";a="4296807" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 20:49:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="755938825" X-IronPort-AV: E=Sophos;i="6.03,231,1694761200"; d="scan'208";a="755938825" Received: from lkp-server02.sh.intel.com (HELO f64821696465) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 16 Oct 2023 20:49:21 -0700 Received: from kbuild by f64821696465 with local (Exim 4.96) (envelope-from ) id 1qsb55-0008yB-0V; Tue, 17 Oct 2023 03:49:19 +0000 Date: Tue, 17 Oct 2023 11:48:31 +0800 From: kernel test robot To: Ondrej Zary Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Damien Le Moal Subject: drivers/ata/pata_parport/bpck.c:66 bpck_read_regr() warn: inconsistent indenting Message-ID: <202310171126.3ixnN84p-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 58720809f52779dc0f08e53e54b014209d13eebb commit: 72f2b0b2185099dce354c805009f591dda3ab73d drivers/block: Move PARIDE protocol modules to drivers/ata/pata_parport date: 9 months ago config: x86_64-randconfig-161-20231017 (https://download.01.org/0day-ci/archive/20231017/202310171126.3ixnN84p-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20231017/202310171126.3ixnN84p-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310171126.3ixnN84p-lkp@intel.com/ New smatch warnings: drivers/ata/pata_parport/bpck.c:66 bpck_read_regr() warn: inconsistent indenting drivers/ata/pata_parport/bpck.c:160 bpck_read_block() warn: inconsistent indenting drivers/ata/pata_parport/bpck.c:210 bpck_probe_unit() warn: inconsistent indenting drivers/ata/pata_parport/bpck.c:230 bpck_connect() warn: inconsistent indenting drivers/ata/pata_parport/bpck.c:293 bpck_test_proto() warn: inconsistent indenting Old smatch warnings: drivers/ata/pata_parport/bpck.c:161 bpck_read_block() warn: inconsistent indenting drivers/ata/pata_parport/bpck.c:233 bpck_connect() warn: inconsistent indenting drivers/ata/pata_parport/bpck.c:294 bpck_test_proto() warn: inconsistent indenting vim +66 drivers/ata/pata_parport/bpck.c ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 52 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 53 r = regr + cont_map[cont]; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 54 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 55 switch (pi->mode) { ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 56 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 57 case 0: w0(r & 0xf); w0(r); t2(2); t2(4); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 58 l = r1(); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 59 t2(4); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 60 h = r1(); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 61 return j44(l,h); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 62 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 63 case 1: w0(r & 0xf); w0(r); t2(2); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 64 e2(); t2(0x20); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 65 t2(4); h = r0(); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 @66 t2(1); t2(0x20); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 67 return h; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 68 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 69 case 2: ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 70 case 3: ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 71 case 4: w0(r); w2(9); w2(0); w2(0x20); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 72 h = r4(); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 73 w2(0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 74 return h; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 75 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 76 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 77 return -1; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 78 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 79 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 80 static void bpck_write_regr( PIA *pi, int cont, int regr, int val ) ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 81 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 82 { int r; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 83 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 84 r = regr + cont_map[cont]; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 85 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 86 switch (pi->mode) { ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 87 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 88 case 0: ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 89 case 1: w0(r); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 90 t2(2); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 91 w0(val); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 92 o2(); t2(4); t2(1); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 93 break; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 94 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 95 case 2: ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 96 case 3: ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 97 case 4: w0(r); w2(9); w2(0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 98 w0(val); w2(1); w2(3); w2(0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 99 break; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 100 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 101 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 102 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 103 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 104 /* These macros access the bpck registers in native addressing */ ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 105 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 106 #define WR(r,v) bpck_write_regr(pi,2,r,v) ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 107 #define RR(r) (bpck_read_regr(pi,2,r)) ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 108 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 109 static void bpck_write_block( PIA *pi, char * buf, int count ) ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 110 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 111 { int i; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 112 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 113 switch (pi->mode) { ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 114 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 115 case 0: WR(4,0x40); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 116 w0(0x40); t2(2); t2(1); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 117 for (i=0;imode) { ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 155 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 156 case 0: WR(4,0x40); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 157 w0(0x40); t2(2); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 158 for (i=0;iunit; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 203 s = 0; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 204 w2(4); w2(0xe); r2(); t2(2); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 205 o1 = r1()&0xf8; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 206 o0 = r0(); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 207 w0(255-id); w2(4); w0(id); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 208 t2(8); t2(8); t2(8); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 209 t2(2); t = r1()&0xf8; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 @210 f7 = ((id % 8) == 7); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 211 if ((f7) || (t != o1)) { t2(2); s = r1()&0xf8; } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 212 if ((t == o1) && ((!f7) || (s == o1))) { ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 213 w2(0x4c); w0(o0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 214 return 0; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 215 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 216 t2(8); w0(0); t2(2); w2(0x4c); w0(o0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 217 return 1; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 218 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 219 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 220 static void bpck_connect ( PIA *pi ) ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 221 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 222 { pi->saved_r0 = r0(); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 223 w0(0xff-pi->unit); w2(4); w0(pi->unit); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 224 t2(8); t2(8); t2(8); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 225 t2(2); t2(2); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 226 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 227 switch (pi->mode) { ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 228 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 229 case 0: t2(8); WR(4,0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 @230 break; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 231 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 232 case 1: t2(8); WR(4,0x10); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 233 break; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 234 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 235 case 2: ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 236 case 3: ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 237 case 4: w2(0); WR(4,8); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 238 break; ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 239 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 240 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 241 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 242 WR(5,8); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 243 ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 244 if (pi->devtype == PI_PCD) { ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 245 WR(0x46,0x10); /* fiddle with ESS logic ??? */ ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 246 WR(0x4c,0x38); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 247 WR(0x4d,0x88); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 248 WR(0x46,0xa0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 249 WR(0x41,0); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 250 WR(0x4e,8); ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 251 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 252 } ^1da177e4c3f41 drivers/block/paride/bpck.c Linus Torvalds 2005-04-16 253 :::::: The code at line 66 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds :::::: CC: Linus Torvalds -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki