From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B8BCDB474 for ; Tue, 17 Oct 2023 14:15:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343952AbjJQOPR (ORCPT ); Tue, 17 Oct 2023 10:15:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344009AbjJQOPO (ORCPT ); Tue, 17 Oct 2023 10:15:14 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B961F9; Tue, 17 Oct 2023 07:15:11 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id E27E3C0015; Tue, 17 Oct 2023 14:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697552110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+5JqiyTOv3TPqc/V/H+YGYwqd0d676gX7UE8nIxZpE=; b=M4Ad9X85i5+2Mw8Hs1jcxIenMfvWwAXvmf9bQlCU22P4jwZr12Vi74PHJ61pQ6o3I4NhuY 28NeuscGp82NrRV301FM43h9ltbVnX0nXz7b4RZEgOzdzSXrNG0Qs0BxGdmIMYMmzLkwhN eexGYueMEMPaj2s5V+j270mBjcSycuT9sG0Kd61ot2rPJGG2rF0R8KDWgYi4SMbsGttVrO kBfww7QExBigcPaQOczMY3s78FDJpN7LuQanxCrhwJik1X8YdoqGjZ/NoNHla+3Bf3SNYc FaMtuXhcA86iIwDbAZAfAgVLeNFU/IzUoVesGo4T1fAfWvA9de9fR2XZnjjPKA== Date: Tue, 17 Oct 2023 16:15:04 +0200 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Frank Li , Conor Dooley , conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, joe@perches.com, peng.fan@nxp.com, alexander.stein@ew.tq-group.com, haibo.chen@nxp.com, ping.bai@nxp.com, xiaoning.wang@nxp.com, sherry.sun@nxp.com, linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev Subject: Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string Message-ID: <20231017161504.396150aa@xps-13> In-Reply-To: References: <20231016152450.2850498-1-Frank.Li@nxp.com> <20231016-chatroom-regulator-a75f1d8be809@spud> <6110c58a-8003-4889-9a4b-6a7d1821c00e@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, krzysztof.kozlowski@linaro.org wrote on Mon, 16 Oct 2023 22:43:28 +0200: > On 16/10/2023 22:10, Frank Li wrote: > > On Mon, Oct 16, 2023 at 09:57:18PM +0200, Krzysztof Kozlowski wrote: =20 > >> On 16/10/2023 21:32, Frank Li wrote: =20 > >>> On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote: =20 > >>>> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote: =20 > >>>>> In driver, compatible string is silvaco,i3c-master instead of > >>>>> silvaco,i3c-master-v1. =20 > >>>> > >>>> And what makes the driver right & the binding wrong? AFAICT, this is= an > >>>> IP sold by silvaco & the -v1 suffix was explicitly requested during > >>>> review of the binding. =20 > >>> > >>> The driver existed for the long time. DTS files already use > >>> silvaco,i3c-master. > >>> > >>> There are two options, one change doc, the other change dts and drive= rs. > >>> I think change doc is easiest ways. > >>> > >>> If there are v2 in future, we can added silvaco,i3c-master-v2 in futu= re. > >>> > >>> If everyone prefer change drivers and dts, I can work on new patch. J= ust > >>> break back compatiblity. =20 > >> > >> No, because Rob explicitly pointed out too generic name. > >> https://lore.kernel.org/all/20210111200821.GA2978830@robh.at.kernel.or= g/ > >> > >> Is it some way to avoid implementing feedback or how does it work? =20 Not at all, it's my (faithful) fault, I did update the bindings upon Rob request and apparently kept the previous string in the driver. After thinking again I would drop silvaco,i3c-master entirely from the driver, it was never intended to keep it. Thanks, Miqu=C3=A8l