Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string

Frank Li
2023-10-16T19:32:49Z

On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote:
> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
> > In driver, compatible string is silvaco,i3c-master instead of
> > silvaco,i3c-master-v1.
>
> And what makes the driver right & the binding wrong? AFAICT, this is an
> IP sold by silvaco & the -v1 suffix was explicitly requested during
> review of the binding.

The driver existed for the long time. DTS files already use
silvaco,i3c-master.

There are two options, one change doc, the other change dts and drivers.
I think change doc is easiest ways.

If there are v2 in future, we can added silvaco,i3c-master-v2 in future.

If everyone prefer change drivers and dts, I can work on new patch. Just
break back compatiblity.

Frank

>
> Thanks,
> Conor.
>
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > index 133855f11b4f..19e3f75eb45c 100644
> > --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> > @@ -14,7 +14,7 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: silvaco,i3c-master-v1
> > + const: silvaco,i3c-master
> >
> > reg:
> > maxItems: 1
> > @@ -49,7 +49,7 @@ unevaluatedProperties: false
> > examples:
> > - |
> > i3c-master@a0000000 {
> > - compatible = "silvaco,i3c-master-v1";
> > + compatible = "silvaco,i3c-master";
> > clocks = <&zynqmp_clk 71>, <&fclk>, <&sclk>;
> > clock-names = "pclk", "fast_clk", "slow_clk";
> > interrupt-parent = <&gic>;
> > --
> > 2.34.1
> >