Re: [PATCH 1/2] dt-bindings: i3c: Fix silvaco,i3c-master compatible string

Conor Dooley
2023-10-16T17:30:23Z

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote:
> In driver, compatible string is silvaco,i3c-master instead of
> silvaco,i3c-master-v1.

And what makes the driver right & the binding wrong? AFAICT, this is an
IP sold by silvaco & the -v1 suffix was explicitly requested during
review of the binding.

Thanks,
Conor.

>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> index 133855f11b4f..19e3f75eb45c 100644
> --- a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -14,7 +14,7 @@ allOf:
>
> properties:
> compatible:
> - const: silvaco,i3c-master-v1
> + const: silvaco,i3c-master
>
> reg:
> maxItems: 1
> @@ -49,7 +49,7 @@ unevaluatedProperties: false
> examples:
> - |
> i3c-master@a0000000 {
> - compatible = "silvaco,i3c-master-v1";
> + compatible = "silvaco,i3c-master";
> clocks = <&zynqmp_clk 71>, <&fclk>, <&sclk>;
> clock-names = "pclk", "fast_clk", "slow_clk";
> interrupt-parent = <&gic>;
> --
> 2.34.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]