From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3983DCDB482 for ; Tue, 17 Oct 2023 15:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343888AbjJQPAL (ORCPT ); Tue, 17 Oct 2023 11:00:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235102AbjJQO7l (ORCPT ); Tue, 17 Oct 2023 10:59:41 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFA3B35BB for ; Tue, 17 Oct 2023 07:49:58 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 9263EE0009; Tue, 17 Oct 2023 14:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697554190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EKj1C9R90LP8I9gAVutZrILL7DKw51ojM2nAHRNjCCs=; b=TxZk4ixlicRIp/4Ps3f+sezpa4q8mtLWj4oe7Byd36WixDBXRuVjTaFqlgCjCoTUnugI37 i6fruBhlMXWVotKpuFTJ6mlOOsG9tPqM2PPlxZ8mNcRHlxpyj34GGIrKhnRDyPt9TjePd9 szT/b4qoKkak9uqtlBk6eVM+e3nAF5b74j5JlxHME1Q8ZchY03hfxvgJ/i5czh+fdeIpMr bDGXpvLsZJDCVEUemPt6KYmww2exDJixY78LbNNFfQutfMUxw/cHbvO68bDhRWtKqBbJ39 75gEG/4SV5SKotlDLU0L47OwgAEoJi2sQAT6AS344MSYIrP7DYBvTT78EliF1g== Date: Tue, 17 Oct 2023 16:49:46 +0200 From: Miquel Raynal To: Frank Li Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH 1/6] i3c: master: svc: fix race condition in ibi work thread Message-ID: <20231017164946.623abd0d@xps-13> In-Reply-To: References: <20231016153232.2851095-1-Frank.Li@nxp.com> <20231016153232.2851095-2-Frank.Li@nxp.com> <20231017161658.2de6d9f3@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, Frank.li@nxp.com wrote on Tue, 17 Oct 2023 10:37:57 -0400: > On Tue, Oct 17, 2023 at 04:16:58PM +0200, Miquel Raynal wrote: > > Hi Frank, > >=20 > > Frank.Li@nxp.com wrote on Mon, 16 Oct 2023 11:32:27 -0400: > > =20 > > > The ibi work thread operates asynchronously with other transfers, suc= h as > > > svc_i3c_master_priv_xfers(). Introduces mutex protection to ensure th= e =20 > >=20 > > Introduce > > =20 > > > completion of the entire i3c/i2c transaction. =20 > >=20 > > Did you experience faulty conditions or was it reported thanks to > > static analysis? =20 >=20 > Yes, I met. But it needs my slave part patches, which will be ready sent > out review soon. I believe several of the "fixes" in this series are related to newer uses (typically your i3c slave support) which were not in the scope of the original submission. As these new features are not supposed to be backported in stable kernels and because these are new corner cases,you may drop the CC:/Fixes tags to avoid useless backports. Some of them however are real fixes for situations we may happen with the current level of support, please keep the tags in these, and move them all to the beginning of your series. Thanks, Miqu=C3=A8l