From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5372FCDB474 for ; Tue, 17 Oct 2023 12:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343647AbjJQMP2 (ORCPT ); Tue, 17 Oct 2023 08:15:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235116AbjJQMPM (ORCPT ); Tue, 17 Oct 2023 08:15:12 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A1AF1738 for ; Tue, 17 Oct 2023 05:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697544622; x=1729080622; h=date:from:to:cc:subject:message-id:mime-version: content-transfer-encoding; bh=W1J/Hsdq66NFiUeMittL5d3TSwJq6u/CITM9AhIASLU=; b=J1Yz/YPkXH0POejRu7BN3qSDPDvf8FyvUgMhnC8U3XdgeseJIO56COY2 kePaPvBpX6Ddog1m5G6/SSloNB7DsQWPTYFgYp5/1K0BKpEn9kOeoyw8d M6+d7+41lwe9mWiaKm/S0jJ9chQpz5WDLkuS0ypzJJO35wfcuVBKf79QR V/ns0dBkJqoCykmBh6hLqHdoAZT2qFHc4gqvnhQY7UzsfVmYjoTwpHL1s Qy6zNmd3/WQXGJQqoTNAK6YuTdtBy85m/bNWAmG5cMQLvE4jtQD6w7d8X pJ0VaUg7THrVMXuBHmzscLJDjb9/WMOotMiemh0drLoJJOJcDBzhZsvkL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="366023085" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="366023085" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 05:07:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="732696137" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="732696137" Received: from lkp-server02.sh.intel.com (HELO f64821696465) ([10.239.97.151]) by orsmga006.jf.intel.com with ESMTP; 17 Oct 2023 05:07:52 -0700 Received: from kbuild by f64821696465 with local (Exim 4.96) (envelope-from ) id 1qsirW-0009Zd-1F; Tue, 17 Oct 2023 12:07:50 +0000 Date: Tue, 17 Oct 2023 20:07:12 +0800 From: kernel test robot To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Luben Tuikov Subject: drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done' Message-ID: <202310172018.eaPyawVC-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christian, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 213f891525c222e8ed145ce1ce7ae1f47921cb9c commit: 539f9ee4b52a8bec95ff064e22dd2fb1e258e818 drm/scheduler: properly forward fence errors date: 6 months ago config: x86_64-buildonly-randconfig-004-20230906 (https://download.01.org/0day-ci/archive/20231017/202310172018.eaPyawVC-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310172018.eaPyawVC-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202310172018.eaPyawVC-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done' vim +266 drivers/gpu/drm/scheduler/sched_main.c 08fb97de03aa22 Andrey Grodzovsky 2022-09-30 258 71173e787cab9d Luben Tuikov 2020-12-03 259 /** 71173e787cab9d Luben Tuikov 2020-12-03 260 * drm_sched_job_done - complete a job 71173e787cab9d Luben Tuikov 2020-12-03 261 * @s_job: pointer to the job which is done 71173e787cab9d Luben Tuikov 2020-12-03 262 * 71173e787cab9d Luben Tuikov 2020-12-03 263 * Finish the job's fence and wake up the worker thread. 71173e787cab9d Luben Tuikov 2020-12-03 264 */ 539f9ee4b52a8b Christian König 2023-04-17 265 static void drm_sched_job_done(struct drm_sched_job *s_job, int result) 71173e787cab9d Luben Tuikov 2020-12-03 @266 { 71173e787cab9d Luben Tuikov 2020-12-03 267 struct drm_sched_fence *s_fence = s_job->s_fence; 71173e787cab9d Luben Tuikov 2020-12-03 268 struct drm_gpu_scheduler *sched = s_fence->sched; 71173e787cab9d Luben Tuikov 2020-12-03 269 71173e787cab9d Luben Tuikov 2020-12-03 270 atomic_dec(&sched->hw_rq_count); f2f12eb9c32bc7 Christian König 2021-02-02 271 atomic_dec(sched->score); 71173e787cab9d Luben Tuikov 2020-12-03 272 71173e787cab9d Luben Tuikov 2020-12-03 273 trace_drm_sched_process_job(s_fence); 71173e787cab9d Luben Tuikov 2020-12-03 274 71173e787cab9d Luben Tuikov 2020-12-03 275 dma_fence_get(&s_fence->finished); 539f9ee4b52a8b Christian König 2023-04-17 276 drm_sched_fence_finished(s_fence, result); 71173e787cab9d Luben Tuikov 2020-12-03 277 dma_fence_put(&s_fence->finished); 71173e787cab9d Luben Tuikov 2020-12-03 278 wake_up_interruptible(&sched->wake_up_worker); 71173e787cab9d Luben Tuikov 2020-12-03 279 } 71173e787cab9d Luben Tuikov 2020-12-03 280 :::::: The code at line 266 was first introduced by commit :::::: 71173e787cab9db4ca1fa6229477cb3d254bc285 drm/scheduler: Essentialize the job done callback :::::: TO: Luben Tuikov :::::: CC: Christian König -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki