From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C2FCDB483 for ; Wed, 18 Oct 2023 15:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232058AbjJRPqU (ORCPT ); Wed, 18 Oct 2023 11:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345451AbjJROX4 (ORCPT ); Wed, 18 Oct 2023 10:23:56 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A08ED48; Wed, 18 Oct 2023 07:15:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BA83C433CC; Wed, 18 Oct 2023 14:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697638545; bh=vGpK+Pi7RyLYmOTT0dOXU/PSvCQL3AhVx2ZeABK+HqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mXFTUqeqojWESFUaRCPjS0tmlvsfbLqnnPmV3cOXbYVUIkkTCde9zX2pHFTsknXJ4 tokmlCk5mYl2DngmJSIXr5+6UH/qiJ9jo4hayyvyz/ViN3wWQau/mgNq1Puf7OcY8A netbWi4Omhn5oCjFfjrxrChWfqo0fvwGSIVWcPV9+q5HjTmhfsfjSHPITDz8AKNtgh VsxkKgE1dnB3IN82FOx1XLtRj/iAx9VJfU73weS5XY8thQO6pxnZOIbjLMtnT5t/cb afrgf1Ww/TuaedpWMNL7Pkz9m0ttoenRipDmJ/Tz5zX9z4kbIbgm8XswbyT50ZJ/tg y+Vurr8iKRuwQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Javier Carrasco , syzbot+0434ac83f907a1dbdd1e@syzkaller.appspotmail.com, Dmitry Torokhov , Sasha Levin , linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 7/7] Input: powermate - fix use-after-free in powermate_config_complete Date: Wed, 18 Oct 2023 10:15:23 -0400 Message-Id: <20231018141525.1335533-7-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231018141525.1335533-1-sashal@kernel.org> References: <20231018141525.1335533-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.258 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Javier Carrasco [ Upstream commit 5c15c60e7be615f05a45cd905093a54b11f461bc ] syzbot has found a use-after-free bug [1] in the powermate driver. This happens when the device is disconnected, which leads to a memory free from the powermate_device struct. When an asynchronous control message completes after the kfree and its callback is invoked, the lock does not exist anymore and hence the bug. Use usb_kill_urb() on pm->config to cancel any in-progress requests upon device disconnection. [1] https://syzkaller.appspot.com/bug?extid=0434ac83f907a1dbdd1e Signed-off-by: Javier Carrasco Reported-by: syzbot+0434ac83f907a1dbdd1e@syzkaller.appspotmail.com Link: https://lore.kernel.org/r/20230916-topic-powermate_use_after_free-v3-1-64412b81a7a2@gmail.com Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/misc/powermate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/misc/powermate.c b/drivers/input/misc/powermate.c index c4e0e1886061f..6b1b95d58e6b5 100644 --- a/drivers/input/misc/powermate.c +++ b/drivers/input/misc/powermate.c @@ -425,6 +425,7 @@ static void powermate_disconnect(struct usb_interface *intf) pm->requires_update = 0; usb_kill_urb(pm->irq); input_unregister_device(pm->input); + usb_kill_urb(pm->config); usb_free_urb(pm->irq); usb_free_urb(pm->config); powermate_free_buffers(interface_to_usbdev(intf), pm); -- 2.40.1