From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F36CDB47E for ; Wed, 18 Oct 2023 14:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345217AbjJROSa (ORCPT ); Wed, 18 Oct 2023 10:18:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345196AbjJROSQ (ORCPT ); Wed, 18 Oct 2023 10:18:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38C3F49FC; Wed, 18 Oct 2023 07:16:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E900CC433CC; Wed, 18 Oct 2023 14:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697638582; bh=WHnnd90rLnf8jpNRxFcfyRVBWvywCkM/Goa6sLpEoPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yx8s/waTsgP4Mt9MfguFIudKGqszHukXkpyOuLdy15MF0svyXi355L52Jo+vr6dSX hvmnxHe21FPZln+UzdhOIi8cbJlrNz3Jh+zkvyECXoEli1WVHIy6F/SEsKkF9rLsid w5kEMCqYza5fsnUfHc9rAjK9CAn+0ExOQJAqxdtH7q1vWaPUMa4iK4RrX6pwkJYkW5 qeqQnsQ9bJpG63wCdI2rmJauJXM41Vc6DiJpZ2QSi4xDFzmAO/K7PGT8oJ5rY1vfKb mOTnlp+gnT+lS9CniY7T01cKG1Sn1kyXJ8lBDfqcF4lp8MFEp3StTNvFbdVLsHY4NY og5eCYuSFMqBQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhang Shurong , Linus Walleij , Vinod Koul , Sasha Levin , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 4/7] dmaengine: ste_dma40: Fix PM disable depth imbalance in d40_probe Date: Wed, 18 Oct 2023 10:16:09 -0400 Message-Id: <20231018141613.1335848-4-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231018141613.1335848-1-sashal@kernel.org> References: <20231018141613.1335848-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.327 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Shurong [ Upstream commit 0618c077a8c20e8c81e367988f70f7e32bb5a717 ] The pm_runtime_enable will increase power disable depth. Thus a pairing decrement is needed on the error handling path to keep it balanced according to context. We fix it by calling pm_runtime_disable when error returns. Signed-off-by: Zhang Shurong Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/tencent_DD2D371DB5925B4B602B1E1D0A5FA88F1208@qq.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/ste_dma40.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 498d9886ed9bc..bb39b04d67d71 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3678,6 +3678,7 @@ static int __init d40_probe(struct platform_device *pdev) regulator_disable(base->lcpa_regulator); regulator_put(base->lcpa_regulator); } + pm_runtime_disable(base->dev); kfree(base->lcla_pool.alloc_map); kfree(base->lookup_log_chans); -- 2.40.1