From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED4B4CDB483 for ; Wed, 18 Oct 2023 15:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232464AbjJRPy2 (ORCPT ); Wed, 18 Oct 2023 11:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232504AbjJRPy0 (ORCPT ); Wed, 18 Oct 2023 11:54:26 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AEAE118 for ; Wed, 18 Oct 2023 08:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697644460; x=1729180460; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=efWEYbNSPrNMZw5ETi6i0i2V6S/DkOB90d/QiicL5io=; b=gSa0GCvHzAyGQXBAvp+B0DaoB2AkJQFOWyw+lrcBaHRkoThQbjD/L4zs jTIX/Pk7gS/IrRAodiDcdbv9H+CPocwRr4fuWiRXgOzotuEIVtKRj2Pwk FxyG9gcamp5vN14E/EuA+QHzDAmwQYiIo80TBdElthHYqZyqClmwzYse4 tLlZNnky8FROyuScUKQ6nrxngRiuhlTZRPlWOtJn74RubD2YXhC7Ca/lE 6Un74e2aJkn2kry9S1p2AG/8LL3kgzMi6QqIR4fXhYrEncDWgCWz/OwWe PBJ9zqS86AlYL6dNTbFSbh4I8VuWdmeZTD9+nfM3dVQeXbg0LaojU4/nC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="389918974" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="389918974" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 08:54:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10867"; a="750135638" X-IronPort-AV: E=Sophos;i="6.03,235,1694761200"; d="scan'208";a="750135638" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 18 Oct 2023 08:54:17 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8136317F; Wed, 18 Oct 2023 17:59:50 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Sudip Mukherjee , Greg Kroah-Hartman , kernel test robot , Dan Carpenter Subject: [resend, PATCH v1 1/2] parport: Clean up resources correctly when parport_register_port() fails Date: Wed, 18 Oct 2023 17:59:47 +0300 Message-Id: <20231018145948.1367648-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The smatch warns about uncleaned resources in case the parport_register_port() fails: parport_register_port() warn: '&tmp->full_list' not removed from list This is indeed an issue introduced when converting code to use kasprintf(). However, the whole kasprintf() dance in this case is not needed as dev_set_name() can handle the formatted input and produces the same result. So, the solution is to delegate name forming to the dev_set_name() and make device_register() error path to deal with error handling (via put_device() call). Fixes: 8d8ae17eb0de ("parport: Use kasprintf() instead of fixed buffer formatting") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202310180809.hepZB9k6-lkp@intel.com/ Signed-off-by: Andy Shevchenko --- drivers/parport/share.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/parport/share.c b/drivers/parport/share.c index a9a9cb0477ea..048a459ce4b0 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c @@ -361,7 +361,6 @@ static void free_port(struct device *dev) kfree(port->probe_info[d].description); } - kfree(port->name); kfree(port); } @@ -479,16 +478,13 @@ struct parport *parport_register_port(unsigned long base, int irq, int dma, /* * Now that the portnum is known finish doing the Init. */ - tmp->name = kasprintf(GFP_KERNEL, "parport%d", tmp->portnum); - if (!tmp->name) { - kfree(tmp); - return NULL; - } - dev_set_name(&tmp->bus_dev, tmp->name); + dev_set_name(&tmp->bus_dev, "parport%d", tmp->portnum); tmp->bus_dev.bus = &parport_bus_type; tmp->bus_dev.release = free_port; tmp->bus_dev.type = &parport_device_type; + tmp->name = dev_name(&tmp->bus_dev); + for (device = 0; device < 5; device++) /* assume the worst */ tmp->probe_info[device].class = PARPORT_CLASS_LEGACY; -- 2.40.0.1.gaa8946217a0b