Re: drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:25: warning: '%s' directive argument is null

Sunil V L
2023-11-09T05:37:29Z

On Wed, Nov 08, 2023 at 05:21:34PM -0800, Palmer Dabbelt wrote:
> On Wed, 08 Nov 2023 15:23:38 PST (-0800), sunilvl@ventanamicro.com wrote:
> > On Sat, Nov 04, 2023 at 06:24:22AM +0800, kernel test robot wrote:
> > > Hi Sunil,
> > >
> > > FYI, the error/warning still remains.
> > >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head: e392ea4d4d00880bf94550151b1ace4f88a4b17a
> > > commit: a91a9ffbd3a55a0ae1bb75e2b6e85b2a03f64e8f RISC-V: Add support to build the ACPI core
> > > date: 5 months ago
> > > config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20231104/202311040602.sCjU3UXr-lkp@intel.com/config)
> > > compiler: riscv64-linux-gcc (GCC) 13.2.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040602.sCjU3UXr-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202311040602.sCjU3UXr-lkp@intel.com/
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > In file included from drivers/net/wireless/intel/iwlwifi/fw/acpi.c:9:
> > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c: In function 'iwl_acpi_is_ppag_approved':
> > > >> drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:25: warning: '%s' directive argument is null [-Wformat-overflow=]
> > > 1190 | "System vendor '%s' is not in the approved list, disabling PPAG.\n",
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > drivers/net/wireless/intel/iwlwifi/iwl-debug.h:91:56: note: in definition of macro '__IWL_DEBUG_DEV'
> > > 91 | __iwl_dbg(dev, level, limit, __func__, fmt, ##args); \
> > > | ^~~
> > > drivers/net/wireless/intel/iwlwifi/iwl-debug.h:209:41: note: in expansion of macro 'IWL_DEBUG'
> > > 209 | #define IWL_DEBUG_RADIO(p, f, a...) IWL_DEBUG(p, IWL_DL_RADIO, f, ## a)
> > > | ^~~~~~~~~
> > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1189:17: note: in expansion of macro 'IWL_DEBUG_RADIO'
> > > 1189 | IWL_DEBUG_RADIO(fwrt,
> > > | ^~~~~~~~~~~~~~~
> > > drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:41: note: format string is defined here
> > > 1190 | "System vendor '%s' is not in the approved list, disabling PPAG.\n",
> > > | ^~
> > >
> > >
> > > vim +1190 drivers/net/wireless/intel/iwlwifi/fw/acpi.c
> > >
> > > e8e10a37c51c08 Matt Chen 2022-03-04 1187
> > > e8e10a37c51c08 Matt Chen 2022-03-04 1188 if (!dmi_check_system(dmi_ppag_approved_list)) {
> > > e8e10a37c51c08 Matt Chen 2022-03-04 1189 IWL_DEBUG_RADIO(fwrt,
> > > e8e10a37c51c08 Matt Chen 2022-03-04 @1190 "System vendor '%s' is not in the approved list, disabling PPAG.\n",
> > >
> > Hi,
> >
> > This should be fixed once SMBIOS is enabled in RISC-V. So, can this
> > warning be ignored until SMBIOS support is merged for RISC-V?
>
> Maybe we should just have something like this?
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 20971304fdef..cbcd1dcced4d 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config IWLWIFI
> tristate "Intel Wireless WiFi Next Gen AGN - Wireless-N/Advanced-N/Ultimate-N (iwlwifi) "
> - depends on PCI && HAS_IOMEM && CFG80211
> + depends on PCI && HAS_IOMEM && CFG80211 && DMI
> depends on IWLMEI || !IWLMEI
> select FW_LOADER
> help
>
Sure Palmer. This works to resolve the warning but I was bit hesitant to
do this because it appeared only part of the driver code depend on
ACPI/DMI. So, I was not sure adding a dependency would disable the
driver on non-ACPI platforms. Anyway, let me send the patch and see
whether driver maintainer would be okay.

Thanks!
Sunil