drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:25: warning: '%s' directive argument is null

kernel test robot
2023-10-18T15:45:14Z

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 06dc10eae55b5ceabfef287a7e5f16ceea204aa0
commit: a91a9ffbd3a55a0ae1bb75e2b6e85b2a03f64e8f RISC-V: Add support to build the ACPI core
date: 5 months ago
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20231018/202310182347.zS9BxqD4-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231018/202310182347.zS9BxqD4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310182347.zS9BxqD4-lkp@intel.com/

All warnings (new ones prefixed by >>):

In file included from drivers/net/wireless/intel/iwlwifi/fw/acpi.c:9:
drivers/net/wireless/intel/iwlwifi/fw/acpi.c: In function 'iwl_acpi_is_ppag_approved':
>> drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:25: warning: '%s' directive argument is null [-Wformat-overflow=]
1190 | "System vendor '%s' is not in the approved list, disabling PPAG.\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/iwl-debug.h:91:56: note: in definition of macro '__IWL_DEBUG_DEV'
91 | __iwl_dbg(dev, level, limit, __func__, fmt, ##args); \
| ^~~
drivers/net/wireless/intel/iwlwifi/iwl-debug.h:209:41: note: in expansion of macro 'IWL_DEBUG'
209 | #define IWL_DEBUG_RADIO(p, f, a...) IWL_DEBUG(p, IWL_DL_RADIO, f, ## a)
| ^~~~~~~~~
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1189:17: note: in expansion of macro 'IWL_DEBUG_RADIO'
1189 | IWL_DEBUG_RADIO(fwrt,
| ^~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:1190:41: note: format string is defined here
1190 | "System vendor '%s' is not in the approved list, disabling PPAG.\n",
| ^~
--
In file included from drivers/net/wireless/intel/iwlwifi/mvm/../iwl-trans.h:15,
from drivers/net/wireless/intel/iwlwifi/mvm/fw.c:11:
drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_tas_init':
>> drivers/net/wireless/intel/iwlwifi/mvm/fw.c:1167:33: warning: '%s' directive argument is null [-Wformat-overflow=]
1167 | "System vendor '%s' is not in the approved list, disabling TAS in US and Canada.\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/mvm/../iwl-debug.h:91:56: note: in definition of macro '__IWL_DEBUG_DEV'
91 | __iwl_dbg(dev, level, limit, __func__, fmt, ##args); \
| ^~~
drivers/net/wireless/intel/iwlwifi/mvm/../iwl-debug.h:209:41: note: in expansion of macro 'IWL_DEBUG'
209 | #define IWL_DEBUG_RADIO(p, f, a...) IWL_DEBUG(p, IWL_DL_RADIO, f, ## a)
| ^~~~~~~~~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:1166:17: note: in expansion of macro 'IWL_DEBUG_RADIO'
1166 | IWL_DEBUG_RADIO(mvm,
| ^~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:1167:49: note: format string is defined here
1167 | "System vendor '%s' is not in the approved list, disabling TAS in US and Canada.\n",
| ^~

vim +1190 drivers/net/wireless/intel/iwlwifi/fw/acpi.c

e8e10a37c51c08 Matt Chen 2022-03-04 1187
e8e10a37c51c08 Matt Chen 2022-03-04 1188 if (!dmi_check_system(dmi_ppag_approved_list)) {
e8e10a37c51c08 Matt Chen 2022-03-04 1189 IWL_DEBUG_RADIO(fwrt,
e8e10a37c51c08 Matt Chen 2022-03-04 @1190 "System vendor '%s' is not in the approved list, disabling PPAG.\n",

:::::: The code at line 1190 was first introduced by commit
:::::: e8e10a37c51c08b99d272b2e1b3ef70fcd38f9e8 iwlwifi: acpi: move ppag code from mvm to fw/acpi

:::::: TO: Matt Chen <matt.chen@intel.com>
:::::: CC: Luca Coelho <luciano.coelho@intel.com>

--
0-DAY CI Kernel Test Service