From: kernel test robot <yujie.liu@intel.com>
To: Frank Li <Frank.Li@nxp.com>, <miquel.raynal@bootlin.com>
Cc: <oe-kbuild-all@lists.linux.dev>, <Frank.Li@nxp.com>,
<alexandre.belloni@bootlin.com>, <conor.culhane@silvaco.com>,
<imx@lists.linux.dev>, <joe@perches.com>,
<linux-i3c@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] i3c: master: svc: add hot join support
Date: Thu, 19 Oct 2023 09:23:13 +0800 [thread overview]
Message-ID: <202310190611.b14M4mH3-lkp@intel.com> (raw)
In-Reply-To: <20231018205929.3435110-3-Frank.Li@nxp.com>
Hi Frank,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc6 next-20231018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/i3c-master-add-enable-disable-hot-join-in-sys-entry/20231019-051444
base: linus/master
patch link: https://lore.kernel.org/r/20231018205929.3435110-3-Frank.Li%40nxp.com
patch subject: [PATCH v2 2/6] i3c: master: svc: add hot join support
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231019/202310190611.b14M4mH3-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231019/202310190611.b14M4mH3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@intel.com>
| Closes: https://lore.kernel.org/r/202310190611.b14M4mH3-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/i3c/master/svc-i3c-master.c:212: warning: Function parameter or member 'lock' not described in 'svc_i3c_master'
>> drivers/i3c/master/svc-i3c-master.c:212: warning: Function parameter or member 'enabled_events' not described in 'svc_i3c_master'
2 warnings as Errors
vim +212 drivers/i3c/master/svc-i3c-master.c
1c5ee2a77b1bac Clark Wang 2023-05-17 157
dd3c52846d5954 Miquel Raynal 2021-01-21 158 /**
dd3c52846d5954 Miquel Raynal 2021-01-21 159 * struct svc_i3c_master - Silvaco I3C Master structure
dd3c52846d5954 Miquel Raynal 2021-01-21 160 * @base: I3C master controller
dd3c52846d5954 Miquel Raynal 2021-01-21 161 * @dev: Corresponding device
dd3c52846d5954 Miquel Raynal 2021-01-21 162 * @regs: Memory mapping
5496eac6ad7428 Miquel Raynal 2023-08-17 163 * @saved_regs: Volatile values for PM operations
dd3c52846d5954 Miquel Raynal 2021-01-21 164 * @free_slots: Bit array of available slots
dd3c52846d5954 Miquel Raynal 2021-01-21 165 * @addrs: Array containing the dynamic addresses of each attached device
dd3c52846d5954 Miquel Raynal 2021-01-21 166 * @descs: Array of descriptors, one per attached device
dd3c52846d5954 Miquel Raynal 2021-01-21 167 * @hj_work: Hot-join work
dd3c52846d5954 Miquel Raynal 2021-01-21 168 * @ibi_work: IBI work
dd3c52846d5954 Miquel Raynal 2021-01-21 169 * @irq: Main interrupt
dd3c52846d5954 Miquel Raynal 2021-01-21 170 * @pclk: System clock
dd3c52846d5954 Miquel Raynal 2021-01-21 171 * @fclk: Fast clock (bus)
dd3c52846d5954 Miquel Raynal 2021-01-21 172 * @sclk: Slow clock (other events)
dd3c52846d5954 Miquel Raynal 2021-01-21 173 * @xferqueue: Transfer queue structure
dd3c52846d5954 Miquel Raynal 2021-01-21 174 * @xferqueue.list: List member
dd3c52846d5954 Miquel Raynal 2021-01-21 175 * @xferqueue.cur: Current ongoing transfer
dd3c52846d5954 Miquel Raynal 2021-01-21 176 * @xferqueue.lock: Queue lock
dd3c52846d5954 Miquel Raynal 2021-01-21 177 * @ibi: IBI structure
dd3c52846d5954 Miquel Raynal 2021-01-21 178 * @ibi.num_slots: Number of slots available in @ibi.slots
dd3c52846d5954 Miquel Raynal 2021-01-21 179 * @ibi.slots: Available IBI slots
dd3c52846d5954 Miquel Raynal 2021-01-21 180 * @ibi.tbq_slot: To be queued IBI slot
dd3c52846d5954 Miquel Raynal 2021-01-21 181 * @ibi.lock: IBI lock
* @lock: <description>
* @enabled_events: <description>
dd3c52846d5954 Miquel Raynal 2021-01-21 182 */
dd3c52846d5954 Miquel Raynal 2021-01-21 183 struct svc_i3c_master {
dd3c52846d5954 Miquel Raynal 2021-01-21 184 struct i3c_master_controller base;
dd3c52846d5954 Miquel Raynal 2021-01-21 185 struct device *dev;
dd3c52846d5954 Miquel Raynal 2021-01-21 186 void __iomem *regs;
1c5ee2a77b1bac Clark Wang 2023-05-17 187 struct svc_i3c_regs_save saved_regs;
dd3c52846d5954 Miquel Raynal 2021-01-21 188 u32 free_slots;
dd3c52846d5954 Miquel Raynal 2021-01-21 189 u8 addrs[SVC_I3C_MAX_DEVS];
dd3c52846d5954 Miquel Raynal 2021-01-21 190 struct i3c_dev_desc *descs[SVC_I3C_MAX_DEVS];
dd3c52846d5954 Miquel Raynal 2021-01-21 191 struct work_struct hj_work;
dd3c52846d5954 Miquel Raynal 2021-01-21 192 struct work_struct ibi_work;
dd3c52846d5954 Miquel Raynal 2021-01-21 193 int irq;
dd3c52846d5954 Miquel Raynal 2021-01-21 194 struct clk *pclk;
dd3c52846d5954 Miquel Raynal 2021-01-21 195 struct clk *fclk;
dd3c52846d5954 Miquel Raynal 2021-01-21 196 struct clk *sclk;
dd3c52846d5954 Miquel Raynal 2021-01-21 197 struct {
dd3c52846d5954 Miquel Raynal 2021-01-21 198 struct list_head list;
dd3c52846d5954 Miquel Raynal 2021-01-21 199 struct svc_i3c_xfer *cur;
dd3c52846d5954 Miquel Raynal 2021-01-21 200 /* Prevent races between transfers */
dd3c52846d5954 Miquel Raynal 2021-01-21 201 spinlock_t lock;
dd3c52846d5954 Miquel Raynal 2021-01-21 202 } xferqueue;
dd3c52846d5954 Miquel Raynal 2021-01-21 203 struct {
dd3c52846d5954 Miquel Raynal 2021-01-21 204 unsigned int num_slots;
dd3c52846d5954 Miquel Raynal 2021-01-21 205 struct i3c_dev_desc **slots;
dd3c52846d5954 Miquel Raynal 2021-01-21 206 struct i3c_ibi_slot *tbq_slot;
dd3c52846d5954 Miquel Raynal 2021-01-21 207 /* Prevent races within IBI handlers */
dd3c52846d5954 Miquel Raynal 2021-01-21 208 spinlock_t lock;
dd3c52846d5954 Miquel Raynal 2021-01-21 209 } ibi;
85bebb554b09b1 Frank Li 2023-10-16 210 struct mutex lock;
e00571e38f466c Frank Li 2023-10-18 211 int enabled_events;
dd3c52846d5954 Miquel Raynal 2021-01-21 @212 };
dd3c52846d5954 Miquel Raynal 2021-01-21 213
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-10-19 1:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 20:59 [PATCH v2 0/6] i3c: master: some improvment for i3c master Frank Li
2023-10-18 20:59 ` [PATCH v2 1/6] i3c: master: add enable(disable) hot join in sys entry Frank Li
2023-10-20 8:55 ` Zbigniew, Lukwinski
2023-10-20 13:45 ` Miquel Raynal
2023-10-20 14:20 ` Frank Li
2023-10-20 14:33 ` Miquel Raynal
2023-10-20 16:24 ` Frank Li
[not found] ` <8a7ac52e-f102-6f5e-35ab-217e6ecc6ba5@linux.intel.com>
2023-10-20 20:25 ` Alexandre Belloni
2023-10-20 20:36 ` Frank Li
2023-10-20 20:42 ` Zbigniew, Lukwinski
2023-11-05 15:36 ` Frank Li
2023-10-18 20:59 ` [PATCH v2 2/6] i3c: master: svc: add hot join support Frank Li
2023-10-19 1:23 ` kernel test robot [this message]
2023-10-18 20:59 ` [PATCH v2 3/6] i3c: add actual_len in i3c_priv_xfer Frank Li
2023-10-18 20:59 ` [PATCH v2 4/6] i3c: svc: rename read_len as actual_len Frank Li
2023-10-18 20:59 ` [PATCH v2 5/6] i3c: master: svc return actual transfer data len Frank Li
2023-10-18 20:59 ` [PATCH v2 6/6] i3c: add API i3c_dev_gettstatus_format1() to get target device status Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310190611.b14M4mH3-lkp@intel.com \
--to=yujie.liu@intel.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=imx@lists.linux.dev \
--cc=joe@perches.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox