From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57074CDB483 for ; Thu, 19 Oct 2023 10:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344730AbjJSKq2 (ORCPT ); Thu, 19 Oct 2023 06:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232626AbjJSKq0 (ORCPT ); Thu, 19 Oct 2023 06:46:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 951A7197 for ; Thu, 19 Oct 2023 03:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697712336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ua/yfYpU7+zl1l3SSe5ziWE4vmE5rVSZxbl9iCkPeqA=; b=fhTtquwGWZNH+lhWHosMcdnvvop+WsP4a+zTHWIl5tiEdaxPo4BQOPxb1aLKgUryRvkwAA BZ1mSgVtPDioappYVMjL1gSU2/shdAm/s6TbCPflztvIBBTqz9RdDdWhfKWvQ7ROhPpMES kEL3kPDTooScZbqQI762GOQGQ7/vU+Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-_XHSdniDNT6nlfvXM7GD3A-1; Thu, 19 Oct 2023 06:45:29 -0400 X-MC-Unique: _XHSdniDNT6nlfvXM7GD3A-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30e4943ca7fso4748511f8f.3 for ; Thu, 19 Oct 2023 03:45:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697712328; x=1698317128; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ua/yfYpU7+zl1l3SSe5ziWE4vmE5rVSZxbl9iCkPeqA=; b=nLDeGsrKX9990Ct5OYXJBuvaHv2h8HQyI2IjjQisjmasnPVIqrP0SWj/oSgKhhwOsj 2XdBWFCcC+4P9hn1OLj/ZuwfnU6u76G+FHtw3XzQZCmESTkL5Fk392wwauhOzc2vO06c +xNnxcL6ncWi1X5idBrvb6tPdUtQtZXbYGGLDx4pm4lZyX5QHnpVjwh9ybH5IZxx2B9T uTMmx+zWP2NPhB/NtKWxubln96dvOl8L+uzaPV1xZzMAYZNl6sFgzasUN5wCEvy8p9b8 ztKnAt9MoVt6tIgrPT8A+f0l4vuQM04/uGzQK82UGeo1+kQOkielbcTW09o8rbSfiixL ppYg== X-Gm-Message-State: AOJu0YxssgAmQzkYeeQL+9b+s0JPLZk9aYhduWnXr4+I/E6Y4OfYFV4M YKFDL8sfM9zd0U+9k0s6OsCdfiFaqPWwV3hj7L34hR88loWZBdlbdA4+SzXJGjlpMpbjp2s1qse XiBweluOa05gZv4PpP4I6RrDA X-Received: by 2002:a5d:4f06:0:b0:31f:dc60:13b5 with SMTP id c6-20020a5d4f06000000b0031fdc6013b5mr1137628wru.25.1697712328756; Thu, 19 Oct 2023 03:45:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG25/eVk9iv4COKDv+qQlPbnnRO8EIl418/81iMMJYQzOMP8gUFG61SSFa31vdA9nVeHX3V5A== X-Received: by 2002:a5d:4f06:0:b0:31f:dc60:13b5 with SMTP id c6-20020a5d4f06000000b0031fdc6013b5mr1137614wru.25.1697712328383; Thu, 19 Oct 2023 03:45:28 -0700 (PDT) Received: from toolbox ([2001:9e8:89b6:9600:497b:a355:d2a9:2bb]) by smtp.gmail.com with ESMTPSA id i11-20020a5d630b000000b00327bf4f2f14sm4172028wru.88.2023.10.19.03.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:45:28 -0700 (PDT) Date: Thu, 19 Oct 2023 12:45:26 +0200 From: Sebastian Wick To: Pekka Paalanen Cc: Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Clark , Dmitry Baryshkov , Sean Paul , Marijn Suijten , quic_abhinavk@quicinc.com, contact@emersion.fr, laurent.pinchart@ideasonboard.com, ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, wayland-devel@lists.freedesktop.org Subject: Re: [PATCH RFC v6 01/10] drm: Introduce pixel_source DRM plane property Message-ID: <20231019104526.GA755220@toolbox> References: <20230828-solid-fill-v6-0-a820efcce852@quicinc.com> <20230828-solid-fill-v6-1-a820efcce852@quicinc.com> <20230829104816.19122c6d@eldfell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829104816.19122c6d@eldfell> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2023 at 10:48:16AM +0300, Pekka Paalanen wrote: > On Mon, 28 Aug 2023 17:05:07 -0700 > Jessica Zhang wrote: > > > Add support for pixel_source property to drm_plane and related > > documentation. In addition, force pixel_source to > > DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break > > legacy userspace. > > > > This enum property will allow user to specify a pixel source for the > > plane. Possible pixel sources will be defined in the > > drm_plane_pixel_source enum. > > > > Currently, the only pixel sources are DRM_PLANE_PIXEL_SOURCE_FB (the > > default value) and DRM_PLANE_PIXEL_SOURCE_NONE. > > > > Signed-off-by: Jessica Zhang > > --- > > drivers/gpu/drm/drm_atomic_state_helper.c | 1 + > > drivers/gpu/drm/drm_atomic_uapi.c | 4 ++ > > drivers/gpu/drm/drm_blend.c | 90 +++++++++++++++++++++++++++++++ > > drivers/gpu/drm/drm_plane.c | 19 +++++-- > > include/drm/drm_blend.h | 2 + > > include/drm/drm_plane.h | 21 ++++++++ > > 6 files changed, 133 insertions(+), 4 deletions(-) > > ... > > > diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c > > index 6e74de833466..c3c57bae06b7 100644 > > --- a/drivers/gpu/drm/drm_blend.c > > +++ b/drivers/gpu/drm/drm_blend.c > > @@ -185,6 +185,21 @@ > > * plane does not expose the "alpha" property, then this is > > * assumed to be 1.0 > > * > > + * pixel_source: > > + * pixel_source is set up with drm_plane_create_pixel_source_property(). > > + * It is used to toggle the active source of pixel data for the plane. > > + * The plane will only display data from the set pixel_source -- any > > + * data from other sources will be ignored. > > + * > > + * Possible values: > > + * > > + * "NONE": > > + * No active pixel source. > > + * Committing with a NONE pixel source will disable the plane. > > + * > > + * "FB": > > + * Framebuffer source set by the "FB_ID" property. > > + * > > * Note that all the property extensions described here apply either to the > > * plane or the CRTC (e.g. for the background color, which currently is not > > * exposed and assumed to be black). > > This UAPI: > Acked-by: Pekka Paalanen Thanks Jessica, same for me Acked-by: Sebastian Wick > > > Thanks, > pq