From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F171ECDB465 for ; Thu, 19 Oct 2023 12:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345483AbjJSM1s (ORCPT ); Thu, 19 Oct 2023 08:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235337AbjJSM1q (ORCPT ); Thu, 19 Oct 2023 08:27:46 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DA9B121 for ; Thu, 19 Oct 2023 05:27:44 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67101C433C8; Thu, 19 Oct 2023 12:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697718464; bh=6pLtasYutjsQq5OHpq4USMERf4M+2OpzADP2WRftPh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TNsTLVhE1DiIT6iCpLU2mPTrlzxXXXgtBTRQP0L7NT0GtwPwo5O7WH9heGe5EDkqc 0G4zqWNDK4j4tYb5y5BWSgiIm36j2sGOUDSaoHE74Yk8SahZoGuEZySMsorGVLO5bG kvLZhP8c0bK41Io+r/mHQwsfyDWR1MouHiRp/gPgSHH4cJ2lPrdp2vWT7K8GpFLLsc ZbwcTt6gFL5Y1rFW/IqzugorVTlbxnNJn+l3XiEKQ4bxISw9F6/bOKI0rXRWvWhhJq kNkJdIuEv+sTLdD6P3UeJJVahYJS0y3AZx0ffiBfavr+V4TXvRUl1goN/Cr8wahjtY 3RuyAvXpnu9QQ== Date: Thu, 19 Oct 2023 14:27:40 +0200 From: Simon Horman To: Nandha Kumar Singaram Cc: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Coiby Xu , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumaran.4353@gmail.com Subject: Re: [PATCH v2 1/2] staging: qlge: Fix coding style in qlge.h Message-ID: <20231019122740.GG2100445@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2023 at 12:46:00PM -0700, Nandha Kumar Singaram wrote: > Replace all occurrnces of (1< "CHECK" output "Prefer using the BIT macro" > > Signed-off-by: Nandha Kumar Singaram Thanks Nandha, these changes look good to me. But I would like to ask if not updating Q_LEN_V and LEN_V is intentional.