From: Jason Gunthorpe <jgg@nvidia.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: mlx5 ConnectX diagnostic misc driver
Date: Thu, 19 Oct 2023 13:01:45 -0300 [thread overview]
Message-ID: <20231019160145.GS3952@nvidia.com> (raw)
In-Reply-To: <2023101923-tried-provable-72e7@gregkh>
On Thu, Oct 19, 2023 at 05:36:04PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 19, 2023 at 08:24:51AM -0700, Jakub Kicinski wrote:
> > > The ConnectX HW family supported by the mlx5 drivers uses an architecture
> > > where a FW component executes "mailbox RPCs" issued by the driver to make
> > > changes to the device. This results in a complex debugging environment
> > > where the FW component has information and complex low level state that
> > > needs to be accessed to userspace for debugging purposes.
> >
> > You're being very dishonest towards Greg by not telling him that this
> > is a networking device, and the networking maintainers explicitly nacked
> > this backdoor.
Do you have a lore link?
> Well, in this case, no way in hell will I be taking this. If this is a
> networking device, it needs to go through the normal networking driver
> review process, thanks for the heads up.
It is not just a networking device. mlx5 is a giant and complex
multi-subsystem piece of hardware.
This is shared debugging and configuration interface to the device FW
that interacts across all of the different subsystems the driver
supports.
Looking at Saeed's tool capability on his github it is significantly,
but not exclusively supporting RDMA (ie drivers/infiniband), with some
features for the mlx5 VFIO drivers, mlx5 VDPA and a bunch of lowlevel
PCI stuff too.
Calling it a "networking device" in the sense of "it is owned only be
netdev" is not accurate.
We think misc is an appropriate place to put something like this,
there are many other misc drivers that are sort of similar APIs to
access embedded FW to manage and debug it.
Jason
next prev parent reply other threads:[~2023-10-19 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 15:24 mlx5 ConnectX diagnostic misc driver Jakub Kicinski
2023-10-19 15:36 ` Greg Kroah-Hartman
2023-10-19 16:01 ` Jason Gunthorpe [this message]
2023-10-19 16:23 ` Jakub Kicinski
2023-10-19 16:50 ` Jason Gunthorpe
2023-10-19 17:59 ` Saeed Mahameed
2023-10-19 17:11 ` Leon Romanovsky
2023-10-19 16:10 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019160145.GS3952@nvidia.com \
--to=jgg@nvidia.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox