From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E06CDB483 for ; Thu, 19 Oct 2023 15:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346335AbjJSPgR (ORCPT ); Thu, 19 Oct 2023 11:36:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346315AbjJSPgJ (ORCPT ); Thu, 19 Oct 2023 11:36:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 895D8124 for ; Thu, 19 Oct 2023 08:36:07 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAEC3C433C8; Thu, 19 Oct 2023 15:36:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697729767; bh=MDH0593z5jBKtRznEEG57ISvSJ+OQMYzUp3pHBYru0g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yDhrCSLBa25X6++UErtsExqW3w4Z/b6+7PxN4OKBIgujnUn09B/xDscLBzHXrpfYX jDI8K6mIAwSAwFCwNNynkXqisatsX+HbkAlWZe6btEIPjlt1j/3Fs3ICLNbiqfjo+n tHrs8jUBg/Y45tDde6dNyA8nACpukEH/jyPOH1K4= Date: Thu, 19 Oct 2023 17:36:04 +0200 From: Greg Kroah-Hartman To: Jakub Kicinski Cc: Saeed Mahameed , Leon Romanovsky , Jason Gunthorpe , Jiri Pirko , linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: mlx5 ConnectX diagnostic misc driver Message-ID: <2023101923-tried-provable-72e7@gregkh> References: <20231019082451.785aa123@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019082451.785aa123@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2023 at 08:24:51AM -0700, Jakub Kicinski wrote: > > The ConnectX HW family supported by the mlx5 drivers uses an architecture > > where a FW component executes "mailbox RPCs" issued by the driver to make > > changes to the device. This results in a complex debugging environment > > where the FW component has information and complex low level state that > > needs to be accessed to userspace for debugging purposes. > > You're being very dishonest towards Greg by not telling him that this > is a networking device, and the networking maintainers explicitly nacked > this backdoor. Nacked it, because you can't answer basic questions like > "what are the use cases" with more than "custom config and debug". > > Whether Greg wants to take this into the "misc" pile is entirely up > to him, but you gotta give him more context. Well, in this case, no way in hell will I be taking this. If this is a networking device, it needs to go through the normal networking driver review process, thanks for the heads up. greg k-h