From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0837AC001DF for ; Fri, 20 Oct 2023 17:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbjJTRb0 (ORCPT ); Fri, 20 Oct 2023 13:31:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbjJTRbY (ORCPT ); Fri, 20 Oct 2023 13:31:24 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E19CA3 for ; Fri, 20 Oct 2023 10:31:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 578F7C433C7; Fri, 20 Oct 2023 17:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697823082; bh=oljrLmjEHyjWNMK611/7HLPN620cBkukdqqw9gAc6OQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FlgDo8lImAgwGfJ0VCESmLVYH/IR9aoCqYKgaLCh2qXYogJJQ7yy0bIhWU/EnCsuf 5SV+I3PF2qpFnJ9FHqYwYrUknXyMzNfLO0/0bm5lKc2x365MF5pSpthEzH4M3PTnr7 4H6TIeaiDG7zqV4TbB5VbL94lNjRzmveTk8BHJ2zZ631LiwVtvPIv7c4e1RG2zS7Pd JY+lyUXOTcfl3XA+8yjFEvXebDKueNuOYguyXoFOtFHCXEe7sBQR3P52xcPIm+AAik LOaw00oqbSHEzSOBTbX+dj8OytQ2HdgKFg+zjs8+tP5c7Bfw8lSHkXTCMZunwkLmks F3tyWiJ25SzFw== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, acsjakub@amazon.de Subject: Re: [PATCH 0/5] avoid divide-by-zero due to max_nr_accesses overflow Date: Fri, 20 Oct 2023 17:31:20 +0000 Message-Id: <20231020173120.64224-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231020171901.63994-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Oct 2023 17:19:01 +0000 SeongJae Park wrote: > On Thu, 19 Oct 2023 19:49:19 +0000 SeongJae Park wrote: > > > The maximum nr_accesses of given DAMON context can be calculated by > > dividing the aggregation interval by the sampling interval. Some logics > > in DAMON uses the maximum nr_accesses as a divisor. Hence, the value > > shouldn't be zero. Such case is avoided since DAMON avoids setting the > > agregation interval as samller than the sampling interval. However, > > since nr_accesses is unsigned int while the intervals are unsigned long, > > the maximum nr_accesses could be zero while casting. > > Actually, the issue was reported by Jakub, and I didn't add 'Reported-by:' tags > for him. I sure Andrew could add that on his own, but I want to minimize > Andrew's load, so will send v2 of this patchset. Andrew, please let me know if > that doesn't help but only increasing your load. So sent the second version[1] with the "Reported-by: akub Acs " line, but then I noticed the patch is already added to mm queue[2]. Somehow the notification mails delivered bit later than usual. Sorry for making this noise, Andrew. Please add "Reported-by: akub Acs " to already added patches, or replace those with the v2 if possible. Also, please let me know if there's anything I could help. [1] https://lore.kernel.org/damon/20231020172317.64192-1-sj@kernel.org/ [2] https://lore.kernel.org/mm-commits/20231020171847.C6EEAC433C7@smtp.kernel.org/ Thanks, SJ > > > Thanks, > SJ >