From: kernel test robot <lkp@intel.com>
To: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Edward Cree <ecree.xilinx@gmail.com>
Subject: include/linux/netlink.h:116:6: warning: 'sfc: Unsupported: only support mangle ipv4.ttl when we have an exact match on ttl, mask used for match (' directive output truncated writing 104 bytes into a region of size 80
Date: Fri, 20 Oct 2023 18:46:47 +0800 [thread overview]
Message-ID: <202310201835.EOKa6EBx-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ce55c22ec8b223a90ff3e084d842f73cfba35588
commit: 66f728872636e1167aedc5a18be6760083911900 sfc: add decrement ttl by offloading set ipv4 ttl actions
date: 8 weeks ago
config: x86_64-randconfig-016-20231007 (https://download.01.org/0day-ci/archive/20231020/202310201835.EOKa6EBx-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231020/202310201835.EOKa6EBx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310201835.EOKa6EBx-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/uapi/linux/neighbour.h:6:0,
from include/linux/netdevice.h:45,
from include/net/sch_generic.h:5,
from include/net/pkt_cls.h:7,
from drivers/net/ethernet/sfc/tc.c:12:
drivers/net/ethernet/sfc/tc.c: In function 'efx_tc_mangle.isra.17':
>> include/linux/netlink.h:116:6: warning: 'sfc: Unsupported: only support mangle ipv4.ttl when we have an exact match on ttl, mask used for match (' directive output truncated writing 104 bytes into a region of size 80 [-Wformat-truncation=]
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:1155:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:116:6: note: directive argument in the range [0, 254]
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:1155:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:116:6: note: 'snprintf' output between 107 and 110 bytes into a destination of size 80
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:1155:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c: In function 'efx_tc_flower_record_encap_match':
include/linux/netlink.h:116:6: warning: ' conflicts with existing pseudo(MASK) entry for TOS mask ' directive output truncated writing 57 bytes into a region of size between 33 and 39 [-Wformat-truncation=]
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:625:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:116:6: note: directive argument in the range [0, 2147483647]
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:625:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:116:6: note: 'snprintf' output between 103 and 115 bytes into a destination of size 80
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:625:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:116:6: warning: ' conflicts with existing pseudo(MASK) entry for mask ' directive output truncated writing 53 bytes into a region of size between 24 and 33 [-Wformat-truncation=]
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:632:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:116:6: note: directive argument in the range [0, 2147483647]
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:632:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:116:6: note: 'snprintf' output between 102 and 120 bytes into a destination of size 80
if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
"%s" fmt "%s", "", ##args, "") >= \
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netlink.h:131:2: note: in expansion of macro 'NL_SET_ERR_MSG_FMT'
NL_SET_ERR_MSG_FMT((extack), KBUILD_MODNAME ": " fmt, ##args)
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/tc.c:632:5: note: in expansion of macro 'NL_SET_ERR_MSG_FMT_MOD'
NL_SET_ERR_MSG_FMT_MOD(extack,
^~~~~~~~~~~~~~~~~~~~~~
vim +116 include/linux/netlink.h
2d4bc93368f5a0 Johannes Berg 2017-04-12 107
51c352bdbcd23d Edward Cree 2022-10-18 108 /* We splice fmt with %s at each end even in the snprintf so that both calls
51c352bdbcd23d Edward Cree 2022-10-18 109 * can use the same string constant, avoiding its duplication in .ro
51c352bdbcd23d Edward Cree 2022-10-18 110 */
51c352bdbcd23d Edward Cree 2022-10-18 111 #define NL_SET_ERR_MSG_FMT(extack, fmt, args...) do { \
51c352bdbcd23d Edward Cree 2022-10-18 112 struct netlink_ext_ack *__extack = (extack); \
51c352bdbcd23d Edward Cree 2022-10-18 113 \
51c352bdbcd23d Edward Cree 2022-10-18 114 if (!__extack) \
51c352bdbcd23d Edward Cree 2022-10-18 115 break; \
51c352bdbcd23d Edward Cree 2022-10-18 @116 if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \
51c352bdbcd23d Edward Cree 2022-10-18 117 "%s" fmt "%s", "", ##args, "") >= \
51c352bdbcd23d Edward Cree 2022-10-18 118 NETLINK_MAX_FMTMSG_LEN) \
51c352bdbcd23d Edward Cree 2022-10-18 119 net_warn_ratelimited("%s" fmt "%s", "truncated extack: ", \
51c352bdbcd23d Edward Cree 2022-10-18 120 ##args, "\n"); \
51c352bdbcd23d Edward Cree 2022-10-18 121 \
51c352bdbcd23d Edward Cree 2022-10-18 122 do_trace_netlink_extack(__extack->_msg_buf); \
51c352bdbcd23d Edward Cree 2022-10-18 123 \
51c352bdbcd23d Edward Cree 2022-10-18 124 __extack->_msg = __extack->_msg_buf; \
51c352bdbcd23d Edward Cree 2022-10-18 125 } while (0)
51c352bdbcd23d Edward Cree 2022-10-18 126
:::::: The code at line 116 was first introduced by commit
:::::: 51c352bdbcd23d7ce46b06c1e64c82754dc44044 netlink: add support for formatted extack messages
:::::: TO: Edward Cree <ecree.xilinx@gmail.com>
:::::: CC: Jakub Kicinski <kuba@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2023-10-20 10:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310201835.EOKa6EBx-lkp@intel.com \
--to=lkp@intel.com \
--cc=ecree.xilinx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pieter.jansen-van-vuuren@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox