Re: [PATCH iwl-next 5/6] i40e: Consolidate hardware capabilities

Jacob Keller
2023-10-20T21:35:07Z

On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> Fields .caps in i40e_hw and .hw_features in i40e_pf both indicate
> capabilities provided by hardware. Move and merge i40e_pf.hw_features
> into i40e_hw.caps as this is more appropriate place for them and
> adjust their names to I40E_HW_CAP_... convention.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

The hw features values were originally introduced by commit b74f571f59a8
("i40e/i40evf: organize and re-number feature flags") (v4.15), and were
previously part of the normal flags back then.

The hw flags field was used since 07f89be81fa5 ("i40e: Fix basic support
for X722 devices") (v4.5), and appears to have been extended a few times
since its original.

Its good to clean these up and keep them together conceptionally. Thanks!