From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: mchehab@kernel.org
Cc: gregkh@linuxfoundation.org, error27@gmail.com,
linux-staging@lists.linux.dev, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jonathan Bergh <bergh.jonathan@gmail.com>
Subject: [PATCH 1/5] staging: media: av7110: Fix missing newlines after declaration warnings
Date: Sat, 21 Oct 2023 01:23:28 +0200 [thread overview]
Message-ID: <20231020232332.55024-2-bergh.jonathan@gmail.com> (raw)
In-Reply-To: <20231020232332.55024-1-bergh.jonathan@gmail.com>
Fixed the following formatting problem:
* Missing newlines after declarations
Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
---
drivers/staging/media/av7110/av7110_av.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/staging/media/av7110/av7110_av.c b/drivers/staging/media/av7110/av7110_av.c
index 00dd6a7fea64..af3845406626 100644
--- a/drivers/staging/media/av7110/av7110_av.c
+++ b/drivers/staging/media/av7110/av7110_av.c
@@ -149,6 +149,7 @@ int av7110_av_start_record(struct av7110 *av7110, int av,
int av7110_av_start_play(struct av7110 *av7110, int av)
{
int ret = 0;
+
dprintk(2, "av7110:%p, \n", av7110);
if (av7110->rec_mode)
@@ -183,6 +184,7 @@ int av7110_av_start_play(struct av7110 *av7110, int av)
int av7110_av_stop(struct av7110 *av7110, int av)
{
int ret = 0;
+
dprintk(2, "av7110:%p, \n", av7110);
if (!(av7110->playing & av) && !(av7110->rec_mode & av))
@@ -320,6 +322,7 @@ int av7110_set_volume(struct av7110 *av7110, unsigned int volleft,
int av7110_set_vidmode(struct av7110 *av7110, enum av7110_video_mode mode)
{
int ret;
+
dprintk(2, "av7110:%p, \n", av7110);
ret = av7110_fw_cmd(av7110, COMTYPE_ENCODER, LoadVidCode, 1, mode);
@@ -408,6 +411,7 @@ static inline long aux_ring_buffer_write(struct dvb_ringbuffer *rbuf,
static void play_video_cb(u8 *buf, int count, void *priv)
{
struct av7110 *av7110 = (struct av7110 *) priv;
+
dprintk(2, "av7110:%p, \n", av7110);
if ((buf[3] & 0xe0) == 0xe0) {
@@ -420,6 +424,7 @@ static void play_video_cb(u8 *buf, int count, void *priv)
static void play_audio_cb(u8 *buf, int count, void *priv)
{
struct av7110 *av7110 = (struct av7110 *) priv;
+
dprintk(2, "av7110:%p, \n", av7110);
aux_ring_buffer_write(&av7110->aout, buf, count);
@@ -471,6 +476,7 @@ static ssize_t dvb_play(struct av7110 *av7110, const char __user *buf,
unsigned long count, int nonblock, int type)
{
unsigned long todo = count, n;
+
dprintk(2, "av7110:%p, \n", av7110);
if (!av7110->kbuf[type])
@@ -504,6 +510,7 @@ static ssize_t dvb_play_kernel(struct av7110 *av7110, const u8 *buf,
unsigned long count, int nonblock, int type)
{
unsigned long todo = count, n;
+
dprintk(2, "av7110:%p, \n", av7110);
if (!av7110->kbuf[type])
@@ -534,6 +541,7 @@ static ssize_t dvb_aplay(struct av7110 *av7110, const char __user *buf,
unsigned long count, int nonblock, int type)
{
unsigned long todo = count, n;
+
dprintk(2, "av7110:%p, \n", av7110);
if (!av7110->kbuf[type])
@@ -1039,6 +1047,7 @@ static int play_iframe(struct av7110 *av7110, char __user *buf, unsigned int len
/* search in buf for instances of 00 00 01 b5 1? */
for (i = 0; i < len; i++) {
unsigned char c;
+
if (get_user(c, buf + i))
return -EFAULT;
if (match == 5) {
@@ -1223,6 +1232,7 @@ static int dvb_video_ioctl(struct file *file,
case VIDEO_SET_DISPLAY_FORMAT:
{
video_displayformat_t format = (video_displayformat_t) arg;
+
switch (format) {
case VIDEO_PAN_SCAN:
av7110->display_panscan = VID_PAN_SCAN_PREF;
@@ -1483,6 +1493,7 @@ static int dvb_audio_ioctl(struct file *file,
case AUDIO_SET_MIXER:
{
struct audio_mixer *amix = (struct audio_mixer *)parg;
+
ret = av7110_set_volume(av7110, amix->volume_left, amix->volume_right);
break;
}
--
2.40.1
next prev parent reply other threads:[~2023-10-20 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 23:23 [PATCH 0/5] staging: media: av7110: Fix various formatting and small code issues Jonathan Bergh
2023-10-20 23:23 ` Jonathan Bergh [this message]
2023-10-20 23:23 ` [PATCH 2/5] staging: media: av7110: Fix various whitespace checkpatch errors Jonathan Bergh
2023-10-23 14:26 ` Dan Carpenter
2023-10-23 15:24 ` Joe Perches
2023-10-24 4:12 ` Dan Carpenter
2023-10-20 23:23 ` [PATCH 3/5] staging: media: av7110: Remove unnecessary whitespace before quoted newlines Jonathan Bergh
2023-10-23 14:27 ` Dan Carpenter
2023-10-20 23:23 ` [PATCH 4/5] staging: media: av7110: Fix 'long int' and 'unsigned' variable declarations Jonathan Bergh
2023-10-20 23:23 ` [PATCH 5/5] staging: media: av7110: Fix various formating issues Jonathan Bergh
2023-10-23 14:32 ` Dan Carpenter
2023-11-22 10:57 ` [PATCH 0/5] staging: media: av7110: Fix various formatting and small code issues Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020232332.55024-2-bergh.jonathan@gmail.com \
--to=bergh.jonathan@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox