From: Greg KH <gregkh@linuxfoundation.org>
To: srinivas.kandagatla@linaro.org
Cc: linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 4/6] Revert "nvmem: add new config option"
Date: Sat, 21 Oct 2023 19:18:14 +0200 [thread overview]
Message-ID: <2023102100-tile-spinning-fa1b@gregkh> (raw)
In-Reply-To: <20231020105545.216052-5-srinivas.kandagatla@linaro.org>
On Fri, Oct 20, 2023 at 11:55:43AM +0100, srinivas.kandagatla@linaro.org wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This reverts commit 517f14d9cf3533d5ab4fded195ab6f80a92e378f.
>
> It seems that "no_of_node" config option was added to help mtd's case.
>
> DT nodes of MTD partitions (that are also NVMEM devices) may contain
> subnodes that SHOULD NOT be treated as NVMEM fixed cells. To prevent
> NVMEM core code from parsing them "no_of_node" was set to true and that
> made for_each_child_of_node() in NVMEM a no-op.
>
> With the introduction of "add_legacy_fixed_of_cells" config option
> things got more explicit. MTD subsystem simply tells NVMEM when to look
> for fixed cells and there is no need to hack "of_node" pointer anymore.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Why isn't this also marked for stable trees?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-21 17:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 10:55 [PATCH 0/6] nvmem: patches for v6.7 srinivas.kandagatla
2023-10-20 10:55 ` [PATCH 1/6] nvmem: qfprom: Mark core clk as optional srinivas.kandagatla
2023-10-20 10:55 ` [PATCH 2/6] nvmem: add explicit config option to read old syntax fixed OF cells srinivas.kandagatla
2023-10-20 10:55 ` [PATCH 3/6] dt-bindings: nvmem: move deprecated cells binding to its own file srinivas.kandagatla
2023-10-20 10:55 ` [PATCH 4/6] Revert "nvmem: add new config option" srinivas.kandagatla
2023-10-21 17:18 ` Greg KH [this message]
2023-10-21 20:31 ` Rafał Miłecki
2023-10-21 20:51 ` Greg KH
2023-10-21 20:56 ` Rafał Miłecki
2023-10-20 10:55 ` [PATCH 5/6] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas srinivas.kandagatla
2023-10-20 10:55 ` [PATCH 6/6] nvmem: Use device_get_match_data() srinivas.kandagatla
2023-10-21 17:20 ` [PATCH 0/6] nvmem: patches for v6.7 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102100-tile-spinning-fa1b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox