From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Jonathan Bergh <bergh.jonathan@gmail.com>
Subject: [PATCH v3 7/7] staging: octeon: Fix introduction of new typedef cvmx_pko_port_status_t in octeon driver
Date: Sat, 21 Oct 2023 12:12:38 +0200 [thread overview]
Message-ID: <20231021101238.81466-8-bergh.jonathan@gmail.com> (raw)
In-Reply-To: <20231021101238.81466-1-bergh.jonathan@gmail.com>
This patch removes the introduction of a new struct typedef
cvmx_pko_port_status_t in the octeon driver and then fixes the
implementations which used it.
Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
---
Changelog:
v1 -> v2: Fix breaking change spread across multiple patches
v2 -> v3: Break changes up into individual patches for each removed
typedef
drivers/staging/octeon/ethernet.c | 2 +-
drivers/staging/octeon/octeon-stubs.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 8c48acab49e4..8e1f4b987a25 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -202,7 +202,7 @@ EXPORT_SYMBOL(cvm_oct_free_work);
static struct net_device_stats *cvm_oct_common_get_stats(struct net_device *dev)
{
struct cvmx_pip_port_status rx_status;
- cvmx_pko_port_status_t tx_status;
+ struct cvmx_pko_port_status tx_status;
struct octeon_ethernet *priv = netdev_priv(dev);
if (priv->port < CVMX_PIP_NUM_INPUT_PORTS) {
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 33a0e1d5f961..cf7f77061eb9 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -409,11 +409,11 @@ struct cvmx_pip_port_status {
uint16_t inb_errors;
};
-typedef struct {
+struct cvmx_pko_port_status {
uint32_t packets;
uint64_t octets;
uint64_t doorbell;
-} cvmx_pko_port_status_t;
+};
union cvmx_pip_frm_len_chkx {
uint64_t u64;
@@ -1262,7 +1262,7 @@ static inline void cvmx_pip_get_port_status(uint64_t port_num, uint64_t clear,
{ }
static inline void cvmx_pko_get_port_status(uint64_t port_num, uint64_t clear,
- cvmx_pko_port_status_t *status)
+ struct cvmx_pko_port_status *status)
{ }
static inline enum cvmx_helper_interface_mode cvmx_helper_interface_get_mode(int
--
2.40.1
next prev parent reply other threads:[~2023-10-21 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 10:12 [PATCH v3 0/7] staging: octeon: Fix warnings due to introduction of new typedefs Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 1/7] staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t in octeon Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 2/7] staging: octeon: Fix up introduction of new typedef cvmx_helper_interface_mode_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 3/7] staging: octeon: Fix introduction of following new typedef cvmx_pow_wait_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 4/7] staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 5/7] staging: octeon: Fix introduction of new typedef cvmx_pko_status_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 6/7] staging: octeon: Fix introduction of new typedef cvmx_pip_port_status_t " Jonathan Bergh
2023-10-21 10:12 ` Jonathan Bergh [this message]
2023-10-21 20:54 ` [PATCH v3 0/7] staging: octeon: Fix warnings due to introduction of new typedefs Greg KH
2023-10-23 14:41 ` Dan Carpenter
2023-10-26 20:02 ` Jonathan Bergh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231021101238.81466-8-bergh.jonathan@gmail.com \
--to=bergh.jonathan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox