Re: [PATCH v8 2/8] hugetlb: restructure pool allocations

Muchun Song
2023-10-19T03:12:17Z

> On Oct 19, 2023, at 10:31, Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> Allocation of a hugetlb page for the hugetlb pool is done by the routine
> alloc_pool_huge_page. This routine will allocate contiguous pages from
> a low level allocator, prep the pages for usage as a hugetlb page and
> then add the resulting hugetlb page to the pool.
>
> In the 'prep' stage, optional vmemmap optimization is done. For
> performance reasons we want to perform vmemmap optimization on multiple
> hugetlb pages at once. To do this, restructure the hugetlb pool
> allocation code such that vmemmap optimization can be isolated and later
> batched.
>
> The code to allocate hugetlb pages from bootmem was also modified to
> allow batching.
>
> No functional changes, only code restructure.
>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>

The difference is small compared with v7. So

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.