From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Ricky WU <ricky_wu@realtek.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264
Date: Sat, 21 Oct 2023 22:57:06 +0200 [thread overview]
Message-ID: <2023102153-paramedic-washboard-29e3@gregkh> (raw)
In-Reply-To: <121ced554a9e4f4791018e8f6a72d586@realtek.com>
On Fri, Oct 20, 2023 at 08:13:46AM +0000, Ricky WU wrote:
> In order to support new chip rts5264, the definitions of some internal
> registers and workflow have to be modified.
That is fine, but that should be a single patch, right?
> Added rts5264.c rts5264.h for independent functions of the new chip rts5264
And then add new support in a new patch, this is still too big as one
patch to attempt to review it properly. Would you like to review this
as-is?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-21 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 8:13 [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264 Ricky WU
2023-10-21 20:57 ` gregkh [this message]
2023-10-23 3:31 ` Ricky WU
2023-10-25 10:39 ` gregkh
2023-10-27 8:25 ` Ricky WU
2023-10-27 8:44 ` gregkh
-- strict thread matches above, loose matches on Subject: below --
2023-10-19 3:08 Ricky WU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023102153-paramedic-washboard-29e3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=frank.li@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox