Re: [PATCH 2/5] selftests/nolibc: use EFI -bios for LoongArch qemu

Willy Tarreau
2023-10-22T09:21:16Z

Hi Thomas,

On Tue, Oct 10, 2023 at 02:33:57PM +0200, Thomas Weißschuh wrote:
> qemu for LoongArch does not work properly with direct kernel boot.
> The kernel will panic during initialization and hang without any output.
>
> When booting in EFI mode everything work correctly.
>
> While users most likely don't have the LoongArch EFI binary installed at
> least an explicit error about 'file not found' is better than a hanging
> test without output that can never succeed.

Agreed. Let's hope at least users will be able to figure what's
missing depending on the message. There's one thing, though, you
hard-coded the path to the file system, and it's unlikely to be
located at the same place for everyone:

-bios /usr/share/edk2/loongarch64/OVMF_CODE.fd

Sure, it's also possible to force QEMU_ARGS but it's becoming complicated
due to the numerous arguments. Maybe use a QEMU_BIOS_loongarch variable
for this ? This way if this starts to generalize to other archs, we can
later simplify it and automatically append -bios when needed.

> Link: https://lore.kernel.org/loongarch/1738d60a-df3a-4102-b1da-d16a29b6e06a@t-8ch.de/
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>
> ---
> Note: I'm wondering how this worked for anybody else.

Not much surprised. As I mentioned, my qemu currently doesn't support
loongarch so I didn't boot that one. Maybe Zhangjin had this one as
part of his other patches.

Overall, on the principle, Acked-by: Willy Tarreau <w@1wt.eu>

Thanks!
Willy