Re: [PATCH 3/5] selftests/nolibc: anchor paths in $(srcdir) if possible

Willy Tarreau
2023-10-22T09:22:55Z

On Tue, Oct 10, 2023 at 02:33:58PM +0200, Thomas Weißschuh wrote:
> It is easier to recognize paths from their well-known location in the
> source tree than having to resolve the relative path in ones head.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> tools/testing/selftests/nolibc/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
> index 258293639572..598d53c5cb7b 100644
> --- a/tools/testing/selftests/nolibc/Makefile
> +++ b/tools/testing/selftests/nolibc/Makefile
> @@ -167,7 +167,7 @@ sysroot: sysroot/$(ARCH)/include
> sysroot/$(ARCH)/include:
> $(Q)rm -rf sysroot/$(ARCH) sysroot/sysroot
> $(QUIET_MKDIR)mkdir -p sysroot
> - $(Q)$(MAKE) -C ../../../include/nolibc ARCH=$(ARCH) OUTPUT=$(CURDIR)/sysroot/ headers_standalone
> + $(Q)$(MAKE) -C $(srctree)/tools/include/nolibc ARCH=$(ARCH) OUTPUT=$(CURDIR)/sysroot/ headers_standalone
> $(Q)mv sysroot/sysroot sysroot/$(ARCH)
>
> ifneq ($(NOLIBC_SYSROOT),0)
> @@ -177,7 +177,7 @@ nolibc-test: nolibc-test.c sysroot/$(ARCH)/include
> else
> nolibc-test: nolibc-test.c
> $(QUIET_CC)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ \
> - -nostdlib -static -include ../../../include/nolibc/nolibc.h $< -lgcc
> + -nostdlib -static -include $(srctree)/tools/include/nolibc/nolibc.h $< -lgcc
> endif

Agreed, this comes from the early days where we didn't have srctree,
that's better this way.

Acked-by: Willy Tarreau <w@1wt.eu>

Willy