From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Shuah Khan <shuah@kernel.org>, Zhangjin Wu <falcon@tinylab.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] selftests/nolibc: support out-of-tree builds
Date: Sun, 22 Oct 2023 11:31:17 +0200 [thread overview]
Message-ID: <20231022093117.GE2669@1wt.eu> (raw)
In-Reply-To: <20231010-nolibc-out-of-tree-v1-4-b6a263859596@weissschuh.net>
On Tue, Oct 10, 2023 at 02:33:59PM +0200, Thomas Weißschuh wrote:
> Out of tree builds are much more convenient when building for multiple
> architectures or configurations in parallel.
>
> Only absolute O= parameters are supported as Makefile.include will
> always resolve relative paths in relation to $(srctree) instead of the
> current directory.
>
> Add a call to "make outputmakefile" to verify that the sourcetree is
> clean.
At first this worried me, I thought you meant clean in the git meaning,
but it's clean as in "make clean" from what I'm seeing. Yeah that sounds
reasonable.
> This is based on Zhangjins out-of-tree patch.
> It extends that work for get_init_cpio support and also drops relative
> O= specifications explicitly.
Yeah I remember these discussions about these shortcomings, that's
pretty reasonable.
> Link: https://lore.kernel.org/lkml/06d96bd81fe812a9718098a383678ad3beba98b1.1691215074.git.falcon@tinylab.org/
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
(...)
I think you should add a Suggested-by at least since Zhangjin attempted
that work quite a few times already and allowed to make progress in that
direction (maybe even co-developed, I'm not sure).
Acked-by: Willy Tarreau <w@1wt.eu>
Willy
next prev parent reply other threads:[~2023-10-22 9:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 12:33 [PATCH 0/5] selftests/nolibc: various build improvements Thomas Weißschuh
2023-10-10 12:33 ` [PATCH 1/5] selftests/nolibc: use qemu-system-ppc64 also for ppc64le Thomas Weißschuh
2023-10-10 12:33 ` [PATCH 2/5] selftests/nolibc: use EFI -bios for LoongArch qemu Thomas Weißschuh
2023-10-22 9:20 ` Willy Tarreau
2023-10-24 16:06 ` Thomas Weißschuh
2023-10-24 16:13 ` Willy Tarreau
2023-10-10 12:33 ` [PATCH 3/5] selftests/nolibc: anchor paths in $(srcdir) if possible Thomas Weißschuh
2023-10-22 9:22 ` Willy Tarreau
2023-10-10 12:33 ` [PATCH 4/5] selftests/nolibc: support out-of-tree builds Thomas Weißschuh
2023-10-22 9:31 ` Willy Tarreau [this message]
2023-10-24 16:09 ` Thomas Weißschuh
2023-10-26 17:50 ` Zhangjin Wu
2023-10-10 12:34 ` [PATCH 5/5] selftests/nolibc: generate config automatically Thomas Weißschuh
2023-10-22 9:36 ` Willy Tarreau
2023-10-24 16:17 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231022093117.GE2669@1wt.eu \
--to=w@1wt.eu \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox