From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4821CC07545 for ; Sun, 22 Oct 2023 09:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbjJVJhG (ORCPT ); Sun, 22 Oct 2023 05:37:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjJVJhF (ORCPT ); Sun, 22 Oct 2023 05:37:05 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C4F9E93; Sun, 22 Oct 2023 02:37:03 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 39M9ap59003563; Sun, 22 Oct 2023 11:36:51 +0200 Date: Sun, 22 Oct 2023 11:36:51 +0200 From: Willy Tarreau To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Shuah Khan , Zhangjin Wu , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] selftests/nolibc: generate config automatically Message-ID: <20231022093651.GF2669@1wt.eu> References: <20231010-nolibc-out-of-tree-v1-0-b6a263859596@weissschuh.net> <20231010-nolibc-out-of-tree-v1-5-b6a263859596@weissschuh.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231010-nolibc-out-of-tree-v1-5-b6a263859596@weissschuh.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 10, 2023 at 02:34:00PM +0200, Thomas Weißschuh wrote: > This new target generates a .config if none exists yet. > > Also drop the defconfig target with its hidden call to 'mrproper' which > is fairly invasive. > If users want to overwrite their kernel existing kernel configuration > they can do so easily from the toplevel directory. Hmmm I'm not sure about that one, I pretty much remember seeing failing arm64 builds when mrproper and prepare were missing. I would argue that someone starting "make defconfig" does expect the config to be dropped, hence mrproper to be called as well. What specific issue did you face with it ? Maybe we can restrict it to only a few cases ? Willy