From: Arnd Bergmann <arnd@kernel.org>
To: Martin Tuma <martin.tuma@digiteqautomotive.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] media: pci: mgb4: add COMMON_CLK dependency
Date: Mon, 23 Oct 2023 18:05:31 +0200 [thread overview]
Message-ID: <20231023160539.1537355-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
This driver fails to build when HAVE_CLK and COMMON_CLK are disabled:
x86_64-linux-ld: vmlinux.o: in function `mgb4_remove':
mgb4_core.c:(.text+0x1915e8c): undefined reference to `clkdev_drop'
x86_64-linux-ld: mgb4_core.c:(.text+0x1915e98): undefined reference to `clk_hw_unregister'
Add a Kconfig dependency to enforce a clean build.
Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/pci/mgb4/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig
index 13fad15a434c..f2a05a1c8ffa 100644
--- a/drivers/media/pci/mgb4/Kconfig
+++ b/drivers/media/pci/mgb4/Kconfig
@@ -2,6 +2,7 @@
config VIDEO_MGB4
tristate "Digiteq Automotive MGB4 support"
depends on VIDEO_DEV && PCI && I2C && DMADEVICES && SPI && MTD && IIO
+ depends on COMMON_CLK
select VIDEOBUF2_DMA_SG
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
--
2.39.2
next reply other threads:[~2023-10-23 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 16:05 Arnd Bergmann [this message]
2023-10-23 16:05 ` [PATCH 2/2] media: pci: mgb4: remove bogus 'select' statements Arnd Bergmann
2023-10-24 13:27 ` Arnd Bergmann
2023-10-24 16:18 ` Lizhi Hou
[not found] ` <25173a48-529c-463b-88aa-2ee75dd604ff@gpxsee.org>
2023-11-08 16:13 ` Arnd Bergmann
2023-11-08 18:33 ` Martin Tůma
2023-11-10 14:37 ` Arnd Bergmann
2023-11-13 14:57 ` Hans Verkuil
2023-12-06 9:18 ` Hans Verkuil
2023-11-06 10:45 ` [PATCH 1/2] media: pci: mgb4: add COMMON_CLK dependency Martin Tůma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023160539.1537355-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.tuma@digiteqautomotive.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox