From: Kees Cook <keescook@chromium.org>
To: Mike Snitzer <snitzer@kernel.org>
Cc: Alasdair Kergon <agk@redhat.com>,
dm-devel@lists.linux.dev, Justin Stitt <justinstitt@google.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: dm crypt: replace open-coded kmemdup_nul
Date: Tue, 24 Oct 2023 14:35:04 -0700 [thread overview]
Message-ID: <202310241434.54EF4068@keescook> (raw)
In-Reply-To: <ZTg4GA005km7mmgC@redhat.com>
On Tue, Oct 24, 2023 at 05:33:12PM -0400, Mike Snitzer wrote:
> On Tue, Oct 24 2023 at 5:18P -0400,
> Kees Cook <keescook@chromium.org> wrote:
>
> > On Mon, 25 Sep 2023 06:35:54 +0000, Justin Stitt wrote:
> > > kzalloc() followed by strncpy() on an expected NUL-terminated string is
> > > just kmemdup_nul(). Let's simplify this code (while also dropping a
> > > deprecated strncpy() call [1]).
> > >
> > >
> >
> > Applied to for-next/hardening, thanks!
> >
> > [1/1] dm crypt: replace open-coded kmemdup_nul
> > https://git.kernel.org/kees/c/17348b0a6a6d
> >
> > Take care,
> >
> > --
> > Kees Cook
> >
>
> I had picked up this patch and the 3 others in my local tree
> yesterday, was going to push shortly... do you still want them to go
> through your hardening tree?
Oh! Great; thank you! I'll drop them from my tree. :)
-Kees
--
Kees Cook
prev parent reply other threads:[~2023-10-24 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 6:35 [PATCH] dm crypt: replace open-coded kmemdup_nul Justin Stitt
2023-09-25 18:04 ` Kees Cook
2023-10-24 21:18 ` Kees Cook
2023-10-24 21:33 ` Mike Snitzer
2023-10-24 21:35 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310241434.54EF4068@keescook \
--to=keescook@chromium.org \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=justinstitt@google.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox