From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 233F7C07545 for ; Tue, 24 Oct 2023 08:31:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233921AbjJXIbo (ORCPT ); Tue, 24 Oct 2023 04:31:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233896AbjJXIbk (ORCPT ); Tue, 24 Oct 2023 04:31:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B37D10D4; Tue, 24 Oct 2023 01:31:36 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C97CFC433C7; Tue, 24 Oct 2023 08:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698136295; bh=ngSvMto7V8dU1ORdVoFSudGElTy/pPNuoVmO5s5fusM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GrW4nr1oaKNjQtuaewrKBG0BcQdOE+2WQdUerNfWacN33AYQPTDEBNjKZWacn7Ezl Ahh0HpsALsA1IyUrk1JU6X4AZmIj+l5nTqOc85Elu85c5PusWhlXV2oTnPcv8virIY xg6nxy9d8tzHRfr8xZ37I2YfwlHNjVifeTW8K0FI= Date: Tue, 24 Oct 2023 10:31:32 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: Geert Uytterhoeven , Daniel =?iso-8859-1?Q?D=EDaz?= , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, Marc Zyngier Subject: Re: [PATCH 5.15 000/137] 5.15.137-rc1 review Message-ID: <2023102453-backspin-immunize-b110@gregkh> References: <20231023104820.849461819@linuxfoundation.org> <724521b8-9c63-4645-b3e0-30d9635573a7@linaro.org> <9737cd7b-f3c6-7e90-f92c-0ceeed788980@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9737cd7b-f3c6-7e90-f92c-0ceeed788980@roeck-us.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2023 at 12:56:48PM -0700, Guenter Roeck wrote: > On 10/23/23 11:50, Geert Uytterhoeven wrote: > > CC maz > > > > On Mon, Oct 23, 2023 at 7:17 PM Daniel Díaz wrote: > > > On Mon, 23 Oct 2023 at 09:11, Daniel Díaz wrote: > > > > On 23/10/23 4:55 a. m., Greg Kroah-Hartman wrote: > > > > > This is the start of the stable review cycle for the 5.15.137 release. > > > > > There are 137 patches in this series, all will be posted as a response > > > > > to this one. If anyone has any issues with these being applied, please > > > > > let me know. > > > > > > > > > > Responses should be made by Wed, 25 Oct 2023 10:47:57 +0000. > > > > > Anything received after that time might be too late. > > > > > > > > > > The whole patch series can be found in one patch at: > > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.137-rc1.gz > > > > > or in the git tree and branch at: > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y > > > > > and the diffstat can be found below. > > > > > > > > > > thanks, > > > > > > > > > > greg k-h > > > > > > > > We see lots of errors on Arm 32-bits: > > > > > > > > -----8<----- > > > > /builds/linux/drivers/gpio/gpio-vf610.c:249:11: error: 'IRQCHIP_IMMUTABLE' undeclared here (not in a function); did you mean 'IS_IMMUTABLE'? > > > > .flags = IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND > > > > ^~~~~~~~~~~~~~~~~ > > > > IS_IMMUTABLE > > > > /builds/linux/drivers/gpio/gpio-vf610.c:251:2: error: 'GPIOCHIP_IRQ_RESOURCE_HELPERS' undeclared here (not in a function) > > > > GPIOCHIP_IRQ_RESOURCE_HELPERS, > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > /builds/linux/drivers/gpio/gpio-vf610.c:251:2: warning: excess elements in struct initializer > > > > /builds/linux/drivers/gpio/gpio-vf610.c:251:2: note: (near initialization for 'vf610_irqchip') > > > > /builds/linux/drivers/gpio/gpio-vf610.c: In function 'vf610_gpio_probe': > > > > /builds/linux/drivers/gpio/gpio-vf610.c:340:2: error: implicit declaration of function 'gpio_irq_chip_set_chip'; did you mean 'gpiochip_get_data'? [-Werror=implicit-function-declaration] > > > > gpio_irq_chip_set_chip(girq, &vf610_irqchip); > > > > ^~~~~~~~~~~~~~~~~~~~~~ > > > > gpiochip_get_data > > > > cc1: some warnings being treated as errors > > > > ----->8----- > > > > > > Bisection points to "gpio: vf610: make irq_chip immutable" (upstream > > > commit e6ef4f8ede09f4af7cde000717b349b50bc62576). > > > > IRQCHIP_IMMUTABLE was introduced in commit 6c846d026d490b23 ("gpio: > > Don't fiddle with irqchips marked as immutable") in v5.19. > > Backporting (part of) that is probably not safe. > > > > In this context: What exactly does commit e6ef4f8ede09 fix that makes it > a stable release candidate ? It is needed as a dependency for 430232619791 ("gpio: vf610: mask the gpio irq in system suspend and support wakeup") which says it: Fixes: 7f2691a19627 ("gpio: vf610: add gpiolib/IRQ chip driver for Vybrid") which was in the 3.19 kernel release. That's why it was added. And then none of my x86 builds caught this build failure before I pushed out the -rcs. thanks, greg k-h