Re: [PATCH v3 1/5] dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC

Krzysztof Kozlowski
2023-10-19T12:48:27Z

On 19/10/2023 13:37, Mrinmay Sarkar wrote:
> Add devicetree bindings support for SA8775P SoC. It has DMA register
> space and dma interrupt to support HDMA.
>
> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com>
> ---
> .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 44 +++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> index a223ce0..7485248 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -13,6 +13,7 @@ properties:
> compatible:
> oneOf:
> - enum:
> + - qcom,sa8775p-pcie-ep
> - qcom,sdx55-pcie-ep
> - qcom,sm8450-pcie-ep
> - items:
> @@ -20,6 +21,7 @@ properties:
> - const: qcom,sdx55-pcie-ep
>
> reg:
> + minItems: 6
> items:
> - description: Qualcomm-specific PARF configuration registers
> - description: DesignWare PCIe registers
> @@ -27,8 +29,10 @@ properties:
> - description: Address Translation Unit (ATU) registers
> - description: Memory region used to map remote RC address space
> - description: BAR memory region
> + - description: DMA register space

You need to constrain IO space in all other variants.

>
> reg-names:
> + minItems: 6
> items:
> - const: parf
> - const: dbi
> @@ -36,13 +40,14 @@ properties:
> - const: atu
> - const: addr_space
> - const: mmio
> + - const: dma
>
> clocks:
> - minItems: 7
> + minItems: 5
> maxItems: 8
>
> clock-names:
> - minItems: 7
> + minItems: 5
> maxItems: 8
>
> qcom,perst-regs:
> @@ -57,14 +62,18 @@ properties:
> - description: Perst separation enable offset
>
> interrupts:
> + minItems: 2
> items:
> - description: PCIe Global interrupt
> - description: PCIe Doorbell interrupt
> + - description: DMA interrupt
>
> interrupt-names:
> + minItems: 2
> items:
> - const: global
> - const: doorbell
> + - const: dma

You need to constrain interrupts in all other variants.

>
> reset-gpios:
> description: GPIO used as PERST# input signal
> @@ -173,6 +182,37 @@ allOf:
> - const: ddrss_sf_tbu
> - const: aggre_noc_axi
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sa8775p-pcie-ep
> + then:
> + properties:
> + reg:
> + minItems: 7

As well:
maxItems: 7
Otherwise any future update will for sure miss this and relax the reg.

> + reg-names:
> + minItems: 7

Ditto

> + clocks:
> + items:
> + - description: PCIe Auxiliary clock
> + - description: PCIe CFG AHB clock
> + - description: PCIe Master AXI clock
> + - description: PCIe Slave AXI clock
> + - description: PCIe Slave Q2A AXI clock
> + clock-names:
> + items:
> + - const: aux
> + - const: cfg
> + - const: bus_master
> + - const: bus_slave
> + - const: slave_q2a
> + interrupts:
> + minItems: 3

Ditto

> + interrupt-names:
> + minItems: 3

Ditto

> +
> unevaluatedProperties: false
>
> examples:

Best regards,
Krzysztof