* [PATCH] hwrng: ingenic: Replace of_device.h with explicit of.h include
@ 2023-10-25 16:20 Rob Herring
2023-11-17 11:20 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-10-25 16:20 UTC (permalink / raw)
To: Olivia Mackall, Herbert Xu; +Cc: linux-crypto, linux-kernel
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other and pull in various other headers. In
preparation to fix this, adjust the includes for what is actually needed.
of_device.h isn't needed, but of.h is and was implicitly included by it.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/char/hw_random/ingenic-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/ingenic-rng.c b/drivers/char/hw_random/ingenic-rng.c
index 4f18c3fa5427..c74ded64fbe3 100644
--- a/drivers/char/hw_random/ingenic-rng.c
+++ b/drivers/char/hw_random/ingenic-rng.c
@@ -11,7 +11,7 @@
#include <linux/io.h>
#include <linux/iopoll.h>
#include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwrng: ingenic: Replace of_device.h with explicit of.h include
2023-10-25 16:20 [PATCH] hwrng: ingenic: Replace of_device.h with explicit of.h include Rob Herring
@ 2023-11-17 11:20 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2023-11-17 11:20 UTC (permalink / raw)
To: Rob Herring; +Cc: Olivia Mackall, linux-crypto, linux-kernel
On Wed, Oct 25, 2023 at 11:20:34AM -0500, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other and pull in various other headers. In
> preparation to fix this, adjust the includes for what is actually needed.
>
> of_device.h isn't needed, but of.h is and was implicitly included by it.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/char/hw_random/ingenic-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-17 11:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-25 16:20 [PATCH] hwrng: ingenic: Replace of_device.h with explicit of.h include Rob Herring
2023-11-17 11:20 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox