Re: [PATCH v2 10/11] percpu: Remove PER_CPU_FIRST_SECTION

Uros Bizjak
2023-10-26T18:51:18Z

On Thu, Oct 26, 2023 at 6:01 PM Brian Gerst <brgerst@gmail.com> wrote:
>
> x86-64 was the only user.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>

Reviewed-by: Uros Bizjak <ubizjak@gmail.com>

> ---
> include/asm-generic/vmlinux.lds.h | 1 -
> include/linux/percpu-defs.h | 12 ------------
> 2 files changed, 13 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 67d8dd2f1bde..23d8acc72760 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -1032,7 +1032,6 @@
> */
> #define PERCPU_INPUT(cacheline) \
> __per_cpu_start = .; \
> - *(.data..percpu..first) \
> . = ALIGN(PAGE_SIZE); \
> *(.data..percpu..page_aligned) \
> . = ALIGN(cacheline); \
> diff --git a/include/linux/percpu-defs.h b/include/linux/percpu-defs.h
> index ec3573119923..b9ddee91e6c7 100644
> --- a/include/linux/percpu-defs.h
> +++ b/include/linux/percpu-defs.h
> @@ -26,13 +26,11 @@
> #define PER_CPU_SHARED_ALIGNED_SECTION "..shared_aligned"
> #define PER_CPU_ALIGNED_SECTION "..shared_aligned"
> #endif
> -#define PER_CPU_FIRST_SECTION "..first"
>
> #else
>
> #define PER_CPU_SHARED_ALIGNED_SECTION ""
> #define PER_CPU_ALIGNED_SECTION "..shared_aligned"
> -#define PER_CPU_FIRST_SECTION ""
>
> #endif
>
> @@ -114,16 +112,6 @@
> #define DEFINE_PER_CPU(type, name) \
> DEFINE_PER_CPU_SECTION(type, name, "")
>
> -/*
> - * Declaration/definition used for per-CPU variables that must come first in
> - * the set of variables.
> - */
> -#define DECLARE_PER_CPU_FIRST(type, name) \
> - DECLARE_PER_CPU_SECTION(type, name, PER_CPU_FIRST_SECTION)
> -
> -#define DEFINE_PER_CPU_FIRST(type, name) \
> - DEFINE_PER_CPU_SECTION(type, name, PER_CPU_FIRST_SECTION)
> -
> /*
> * Declaration/definition used for per-CPU variables that must be cacheline
> * aligned under SMP conditions so that, whilst a particular instance of the
> --
> 2.41.0
>