Re: [PATCH v2 3/3] staging: greybus: bootrom: fixed prefer using ftrace warning

Nandha Kumar Singaram
2023-10-28T20:25:43Z

On Thu, Oct 26, 2023 at 01:20:47PM -0500, Alex Elder wrote:
> On 10/22/23 7:22 AM, Nandha Kumar Singaram wrote:
> > Adhere to linux coding style. Reported by checkpatch.pl:
> > WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> >
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@gmail.com>
>
> This change looks reasonable to me, though I don't think
> ftrace provides device information.
>
> Acked-by: Alex Elder <elder@linaro.org>
>
> > ---
> > drivers/staging/greybus/bootrom.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
> > index a8efb86de140..79581457c4af 100644
> > --- a/drivers/staging/greybus/bootrom.c
> > +++ b/drivers/staging/greybus/bootrom.c
> > @@ -491,8 +491,6 @@ static void gb_bootrom_disconnect(struct gb_bundle *bundle)
> > {
> > struct gb_bootrom *bootrom = greybus_get_drvdata(bundle);
> > - dev_dbg(&bundle->dev, "%s\n", __func__);
> > -
> > gb_connection_disable(bootrom->connection);
> > /* Disable timeouts */
>

Thanks Alex for the review and feedback.

Regards,
Nandha Kumar