From: 'Guanjun' <guanjun@linux.alibaba.com>
To: dave.jiang@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, vkoul@kernel.org,
tony.luck@intel.com, fenghua.yu@intel.com
Cc: jing.lin@intel.com, ashok.raj@intel.com,
sanjay.k.kumar@intel.com, megha.dey@intel.com,
jacob.jun.pan@intel.com, yi.l.liu@intel.com, tglx@linutronix.de
Subject: [PATCH v1 1/2] dmaengine: idxd: Protect int_handle field in hw descriptor
Date: Sun, 29 Oct 2023 16:00:48 +0800 [thread overview]
Message-ID: <20231029080049.1482701-2-guanjun@linux.alibaba.com> (raw)
In-Reply-To: <20231029080049.1482701-1-guanjun@linux.alibaba.com>
From: Guanjun <guanjun@linux.alibaba.com>
The int_handle field in hw descriptor should also be protected
by wmb() before possibly triggering a DMA read.
Signed-off-by: Guanjun <guanjun@linux.alibaba.com>
---
drivers/dma/idxd/submit.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/dma/idxd/submit.c b/drivers/dma/idxd/submit.c
index c01db23e3333..3f922518e3a5 100644
--- a/drivers/dma/idxd/submit.c
+++ b/drivers/dma/idxd/submit.c
@@ -182,13 +182,6 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc)
portal = idxd_wq_portal_addr(wq);
- /*
- * The wmb() flushes writes to coherent DMA data before
- * possibly triggering a DMA read. The wmb() is necessary
- * even on UP because the recipient is a device.
- */
- wmb();
-
/*
* Pending the descriptor to the lockless list for the irq_entry
* that we designated the descriptor to.
@@ -199,6 +192,13 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc)
llist_add(&desc->llnode, &ie->pending_llist);
}
+ /*
+ * The wmb() flushes writes to coherent DMA data before
+ * possibly triggering a DMA read. The wmb() is necessary
+ * even on UP because the recipient is a device.
+ */
+ wmb();
+
if (wq_dedicated(wq)) {
iosubmit_cmds512(portal, desc->hw, 1);
} else {
--
2.39.3
next prev parent reply other threads:[~2023-10-29 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 8:00 [PATCH v1 0/2] Some fixes for idxd driver 'Guanjun'
2023-10-29 8:00 ` 'Guanjun' [this message]
2023-10-30 15:58 ` [PATCH v1 1/2] dmaengine: idxd: Protect int_handle field in hw descriptor Dave Jiang
2023-10-30 18:56 ` Fenghua Yu
2023-10-29 8:00 ` [PATCH v1 2/2] dmaengine: idxd: Fix the incorrect descriptions 'Guanjun'
2023-10-30 16:00 ` Dave Jiang
2023-10-30 19:20 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029080049.1482701-2-guanjun@linux.alibaba.com \
--to=guanjun@linux.alibaba.com \
--cc=ashok.raj@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=jacob.jun.pan@intel.com \
--cc=jing.lin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=sanjay.k.kumar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox