From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D53ACC4332F for ; Tue, 31 Oct 2023 11:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343777AbjJaLhI (ORCPT ); Tue, 31 Oct 2023 07:37:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235614AbjJaLhG (ORCPT ); Tue, 31 Oct 2023 07:37:06 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3930097 for ; Tue, 31 Oct 2023 04:37:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61789C433C8; Tue, 31 Oct 2023 11:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698752223; bh=3SkuphRz/pcBGjkRd9EkXxoSc1kkvEtAro0c6PtXBvk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l1i5Z/YGrmTuWi7xt+sCTEBteTLBqrZt5VrLJbJ+gevmRS4H3HaFY5LuxUGrJkBcp IGruGdJpM5Asgzol+eAgTb9S/AUq+hQoD70WQ2NLw2kp+eAftkLWkT4iZoTVkfH6Y/ TRrtiG8aXIZOFlm5Kra9C4x9qsrzqpaPbQcwtnmA= Date: Tue, 31 Oct 2023 12:36:59 +0100 From: "gregkh@linuxfoundation.org" To: =?utf-8?B?5p+z6I+B5bOw?= Cc: Marco Elver , "rafael@kernel.org" , "linux-kernel@vger.kernel.org" , "security@kernel.org" , "syzkaller@googlegroups.com" Subject: Re: A null-ptr crash in linux-6.4 usb driver Message-ID: <2023103132-flinch-rectified-d758@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2023 at 11:10:45AM +0000, 柳菁峰 wrote: > OK, I took a look and it may be the same reason that caused the > crash,but I just tested it on the latest Linux-6.6,it also crashed > while running the reproducer,it didn't be fixed. Very true, you are injecting faults into the system, so the system faulted! You are succeeding in breaking things. But the trick is, is this actually a valid fault? Or is it something that can never actually happen in real life? That's for you to determine please. > > Looks like this report from over a year ago: > > https://lore.kernel.org/all/000000000000bb7f1c05da29b601@google.com/ > > > It seems that this issue will not be fixed because it must rely on > fault-inject, right? Yes. > I am not familiar with this part of the kernel code, and if fixing > this issue is very difficult, I may not be able to provide an useful > patch,sorry. Try it and see! You have the reproducer, so you are in the best position to work on this. thanks, greg k-h