From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5ABFC4332F for ; Thu, 2 Nov 2023 11:57:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345500AbjKBL5Y (ORCPT ); Thu, 2 Nov 2023 07:57:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjKBL5W (ORCPT ); Thu, 2 Nov 2023 07:57:22 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3C28DC for ; Thu, 2 Nov 2023 04:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zpoyf0umzevL48zlxPDHoMyyBJL1AYvLijGDL66r8U0=; b=Y8nBbUmHyrFCPnUpfg4L/wT/tV Rb9l5vEDe9EsOi3GmhjiXaKLGJNAyhnCPu4XE9yqoSv/3a1b00CCQcPWjs1mJJsxLobKREw0MQQzM 7flM8kXa6gnUknd6kM0i9Rthlrg8YugyVA3/4NmF4VZhqzWjS7GgBBbE6ZSevRlhNB2g1IX/j6p4l D4M7CLHRgDfTSCzb1frM3xspjlE1iRZE+zACAhWakUtlckePnHeLw31IPlrghznuTX/IamKeIZSQk Fy57/AXyMIc8r2koEwuZQ+Pkl5XiERF5TPVM/tckiidjluvqxr1z8++d2RQMQXPPiUb3gIEDSS1G/ mPCcpIrg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qyWJU-006Y20-01; Thu, 02 Nov 2023 11:56:40 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id AA92F3004AB; Thu, 2 Nov 2023 12:56:39 +0100 (CET) Date: Thu, 2 Nov 2023 12:56:39 +0100 From: Peter Zijlstra To: Uros Bizjak Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH 2/3] x86/callthunks: Handle %rip-relative relocations in call thunk template Message-ID: <20231102115639.GC3818@noisy.programming.kicks-ass.net> References: <20231102112850.3448745-1-ubizjak@gmail.com> <20231102112850.3448745-3-ubizjak@gmail.com> <20231102114422.GB3818@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 02, 2023 at 12:50:01PM +0100, Uros Bizjak wrote: > > Remove static, add decl, stuff like that? > > On second thought, you are right. Should I move the above function > somewhere (reloc.c?) , or can I just use it from alternative.c and add > decl (where?) ? Yeah, leave it there for now, perhaps asm/text-patching.h ?