From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
acme@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com
Subject: [PATCH 07/13] perf: Simplify: __perf_install_in_context()
Date: Thu, 02 Nov 2023 16:09:26 +0100 [thread overview]
Message-ID: <20231102152018.499897182@infradead.org> (raw)
In-Reply-To: 20231102150919.719936610@infradead.org
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
kernel/events/core.c | 21 +++++++--------------
1 file changed, 7 insertions(+), 14 deletions(-)
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2732,13 +2732,13 @@ static int __perf_install_in_context(vo
struct perf_cpu_context *cpuctx = this_cpu_ptr(&perf_cpu_context);
struct perf_event_context *task_ctx = cpuctx->task_ctx;
bool reprogram = true;
- int ret = 0;
- raw_spin_lock(&cpuctx->ctx.lock);
- if (ctx->task) {
- raw_spin_lock(&ctx->lock);
+ if (ctx->task)
task_ctx = ctx;
+ guard(perf_ctx_lock)(cpuctx, task_ctx);
+
+ if (ctx->task) {
reprogram = (ctx->task == current);
/*
@@ -2748,14 +2748,10 @@ static int __perf_install_in_context(vo
* If its not running, we don't care, ctx->lock will
* serialize against it becoming runnable.
*/
- if (task_curr(ctx->task) && !reprogram) {
- ret = -ESRCH;
- goto unlock;
- }
+ if (task_curr(ctx->task) && !reprogram)
+ return -ESRCH;
WARN_ON_ONCE(reprogram && cpuctx->task_ctx && cpuctx->task_ctx != ctx);
- } else if (task_ctx) {
- raw_spin_lock(&task_ctx->lock);
}
#ifdef CONFIG_CGROUP_PERF
@@ -2778,10 +2774,7 @@ static int __perf_install_in_context(vo
add_event_to_ctx(event, ctx);
}
-unlock:
- perf_ctx_unlock(cpuctx, task_ctx);
-
- return ret;
+ return 0;
}
static bool exclusive_event_installable(struct perf_event *event,
next prev parent reply other threads:[~2023-11-02 15:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 15:09 [PATCH 00/13] perf: Employ SBRM to simplify error handling -- batch 1/3 Peter Zijlstra
2023-11-02 15:09 ` [PATCH 01/13] perf: Simplify perf_event_alloc() error path Peter Zijlstra
2023-11-03 12:38 ` Jiri Olsa
2023-11-03 19:50 ` Namhyung Kim
2023-11-15 9:58 ` Peter Zijlstra
2023-11-15 15:12 ` Namhyung Kim
2023-11-15 9:31 ` Peter Zijlstra
2023-11-02 15:09 ` [PATCH 02/13] perf: Simplify perf_pmu_register() " Peter Zijlstra
2023-11-02 15:09 ` [PATCH 03/13] perf: Simplify perf_fget_light() Peter Zijlstra
2023-11-02 15:09 ` [PATCH 04/13] perf: Simplify event_function*() Peter Zijlstra
2023-11-02 15:09 ` [PATCH 05/13] perf: Simplify perf_cgroup_connect() Peter Zijlstra
2023-11-02 15:09 ` [PATCH 06/13] perf; Simplify event_sched_in() Peter Zijlstra
2023-11-02 15:09 ` Peter Zijlstra [this message]
2023-11-04 1:08 ` [PATCH 07/13] perf: Simplify: __perf_install_in_context() Namhyung Kim
2023-11-15 9:24 ` Peter Zijlstra
2023-11-02 15:09 ` [PATCH 08/13] perf: Simplify: *perf_event_{dis,en}able*() Peter Zijlstra
2023-11-02 15:09 ` [PATCH 09/13] perf: Simplify perf_event_modify_attr() Peter Zijlstra
2023-11-02 15:09 ` [PATCH 10/13] perf: Simplify perf_event_context_sched_in() Peter Zijlstra
2023-11-02 15:09 ` [PATCH 11/13] perf: Simplify perf_adjust_freq_unthr_context() Peter Zijlstra
2023-11-04 1:14 ` Namhyung Kim
2023-11-15 10:31 ` Peter Zijlstra
2023-11-02 15:09 ` [PATCH 12/13] perf: Simplify perf_event_*_on_exec() Peter Zijlstra
2023-11-02 15:09 ` [PATCH 13/13] perf: Simplify *perf_event_read*() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102152018.499897182@infradead.org \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox