From: "Łukasz Bartosik" <lb@semihalf.com>
To: Jason Baron <jbaron@akamai.com>,
Jim Cromie <jim.cromie@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Douglas Anderson <dianders@chromium.org>
Cc: Guenter Roeck <groeck@google.com>,
Yaniv Tzoreff <yanivt@google.com>,
Benson Leung <bleung@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Whitchurch <vincent.whitchurch@axis.com>,
Pekka Paalanen <ppaalanen@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org, upstream@semihalf.com
Subject: [PATCH v1 07/12] dyndbg: repack struct _ddebug
Date: Fri, 3 Nov 2023 14:10:06 +0100 [thread overview]
Message-ID: <20231103131011.1316396-8-lb@semihalf.com> (raw)
In-Reply-To: <20231103131011.1316396-1-lb@semihalf.com>
From: Jim Cromie <jim.cromie@gmail.com>
Move the JUMP_LABEL to the top of the struct, since theyre both
align(8) and this closes a pahole (unfortunately trading for padding,
but still).
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/linux/dynamic_debug.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 497130816e9c..b9237e4ecd1b 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -14,6 +14,12 @@
* the special section is treated as an array of these.
*/
struct _ddebug {
+#ifdef CONFIG_JUMP_LABEL
+ union {
+ struct static_key_true dd_key_true;
+ struct static_key_false dd_key_false;
+ } key;
+#endif
/*
* These fields are used to drive the user interface
* for selecting and displaying debug callsites.
@@ -53,12 +59,6 @@ struct _ddebug {
#define _DPRINTK_FLAGS_DEFAULT 0
#endif
unsigned int flags:8;
-#ifdef CONFIG_JUMP_LABEL
- union {
- struct static_key_true dd_key_true;
- struct static_key_false dd_key_false;
- } key;
-#endif
} __attribute__((aligned(8)));
enum class_map_type {
--
2.42.0.869.gea05f2083d-goog
next prev parent reply other threads:[~2023-11-03 13:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 13:09 [PATCH v1 00/12] dyndbg: add support for writing debug logs to trace Łukasz Bartosik
2023-11-03 13:10 ` [PATCH v1 01/12] dyndbg: add _DPRINTK_FLAGS_ENABLED Łukasz Bartosik
2023-11-03 13:10 ` [PATCH v1 02/12] dyndbg: add _DPRINTK_FLAGS_TRACE Łukasz Bartosik
2023-11-03 13:10 ` [PATCH v1 03/12] dyndbg: add write-events-to-tracefs code Łukasz Bartosik
2023-11-03 13:10 ` [PATCH v1 04/12] dyndbg: add 2 trace-events: pr_debug, dev_dbg Łukasz Bartosik
2023-11-04 3:26 ` jim.cromie
2023-11-06 23:55 ` Steven Rostedt
2023-11-10 14:50 ` Łukasz Bartosik
2023-11-10 19:20 ` jim.cromie
2023-11-12 16:28 ` Łukasz Bartosik
2023-11-03 13:10 ` [PATCH v1 05/12] tracefs: add TP_printk_no_nl - RFC Łukasz Bartosik
2023-11-04 3:40 ` jim.cromie
2023-11-07 1:40 ` Steven Rostedt
2023-11-03 13:10 ` [PATCH v1 06/12] trace: use TP_printk_no_nl in dyndbg:prdbg,devdbg Łukasz Bartosik
2023-11-07 0:45 ` Steven Rostedt
2023-11-10 14:51 ` Łukasz Bartosik
2023-11-10 19:21 ` jim.cromie
2023-11-03 13:10 ` Łukasz Bartosik [this message]
2023-11-04 1:49 ` [PATCH v1 07/12] dyndbg: repack struct _ddebug jim.cromie
2023-11-10 14:51 ` Łukasz Bartosik
2023-11-10 21:00 ` jim.cromie
2023-11-12 16:28 ` Łukasz Bartosik
2023-11-24 14:38 ` Łukasz Bartosik
2023-11-26 6:00 ` jim.cromie
2023-11-27 22:46 ` Łukasz Bartosik
2023-11-03 13:10 ` [PATCH v1 08/12] dyndbg: move flags field to a new structure Łukasz Bartosik
2023-11-03 20:57 ` kernel test robot
2023-11-03 13:10 ` [PATCH v1 09/12] dyndbg: add trace destination field to _ddebug Łukasz Bartosik
2023-11-04 1:39 ` jim.cromie
2023-11-10 14:51 ` Łukasz Bartosik
2023-11-10 19:37 ` jim.cromie
2023-11-12 16:29 ` Łukasz Bartosik
2023-11-13 19:49 ` jim.cromie
2023-11-03 13:10 ` [PATCH v1 10/12] dyndbg: add processing of T(race) flag argument Łukasz Bartosik
2023-11-03 18:03 ` kernel test robot
2023-11-04 3:05 ` jim.cromie
2023-11-10 14:52 ` Łukasz Bartosik
2023-11-10 19:51 ` jim.cromie
2023-11-12 16:29 ` Łukasz Bartosik
2023-11-13 19:14 ` jim.cromie
2023-11-04 4:33 ` kernel test robot
2023-11-03 13:10 ` [PATCH v1 11/12] dyndbg: write debug logs to trace instance Łukasz Bartosik
2023-11-04 21:48 ` jim.cromie
2023-11-10 14:53 ` Łukasz Bartosik
2023-11-10 20:02 ` jim.cromie
2023-11-12 16:31 ` Łukasz Bartosik
2023-11-13 18:59 ` jim.cromie
2023-11-13 23:44 ` Łukasz Bartosik
2023-11-14 1:08 ` jim.cromie
2023-11-14 7:44 ` Łukasz Bartosik
2023-11-14 15:40 ` jim.cromie
2023-11-14 22:09 ` Łukasz Bartosik
2023-11-03 13:10 ` [PATCH v1 12/12] dyndbg: add trace support for hexdump Łukasz Bartosik
2023-11-04 1:25 ` [PATCH v1 00/12] dyndbg: add support for writing debug logs to trace jim.cromie
2023-11-10 14:49 ` Łukasz Bartosik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231103131011.1316396-8-lb@semihalf.com \
--to=lb@semihalf.com \
--cc=akpm@linux-foundation.org \
--cc=bleung@google.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=groeck@google.com \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ppaalanen@gmail.com \
--cc=rostedt@goodmis.org \
--cc=seanpaul@chromium.org \
--cc=upstream@semihalf.com \
--cc=vincent.whitchurch@axis.com \
--cc=yanivt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox