From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5171BC4332F for ; Fri, 3 Nov 2023 18:53:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345483AbjKCSxp (ORCPT ); Fri, 3 Nov 2023 14:53:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbjKCSxo (ORCPT ); Fri, 3 Nov 2023 14:53:44 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12FB3D45 for ; Fri, 3 Nov 2023 11:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699037574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NCiQx7b6o0I8TtRZwuqX8qo/h0IQ9BycIscN4+R1OH0=; b=HIw19AjR3N6BFQ8N4pLGQACJf1UBdW+zYuZKkBbukMqfrOEJHeqNOR3THDRmdzIDR01xjH 2QvzzuEeAv8KFISmNGSsZngJymya/sblDVLu+qugxVjj8vXw7CFn0MBV/9es+j+uepTsa4 DThiYoJHv0WodnRF9CXYZe9gRr2W7Bw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-vJzT2UxzOjmmLss8mlavUw-1; Fri, 03 Nov 2023 14:52:49 -0400 X-MC-Unique: vJzT2UxzOjmmLss8mlavUw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 725441E441D4; Fri, 3 Nov 2023 18:52:48 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.198]) by smtp.corp.redhat.com (Postfix) with SMTP id B268F10102; Fri, 3 Nov 2023 18:52:46 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 3 Nov 2023 19:51:46 +0100 (CET) Date: Fri, 3 Nov 2023 19:51:43 +0100 From: Oleg Nesterov To: Linus Torvalds Cc: Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , Greg Kroah-Hartman , Eric Biederman Subject: Re: [PATCH 1/2] cleanup: Add conditional guard support Message-ID: <20231103185143.GB26864@redhat.com> References: <20231102104429.025835330@infradead.org> <20231102110706.460851167@infradead.org> <20231102144009.GA9680@redhat.com> <20231103093023.GA8262@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03, Linus Torvalds wrote: > > On Thu, 2 Nov 2023 at 23:30, Peter Zijlstra wrote: > > > > Linus, do you like that enough to suffer a flag day patch as proposed by > > Oleg? > > I don't find myself caring too much whether we have that "double > grouping" of the guard type-vs-arguments or the "(type, arg...)" > syntax. Neither me, > I honestly think that "guard(spinlock)(&lock)" makes it more visually > obvious that the first argument is the "type of guard", while > "guard(spinlock, &lock)" makes it look like the two arguments are > somehow at the same level, which they most definitely aren't. My point was that guard(spinlock)(&lock); doesn't match scoped_guard(spinlock, &lock); but I agree this purely cosmetic, so lets forget it. Oleg.